Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-260] Update Avatar component, deprecate shape prop #212

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Mar 7, 2024

Short description

This PR updates the Avatar component with an inner rounded wrapper to handle edge cases (entity logos without rounded shapes, etc...). It also deprecates the shape prop because the rounded square is the only accepted variant.

List of changes proposed in this pull request

  • Add two different radius values: 8 for small version, 12 for medium one
  • Link the shape radius value to the AnimatedMessageCheckbox component
  • Deprecate shape prop using JSDoc syntax
  • [Extra] Add react-native-easing-gradient as peer dependency

Preview

double-radius-values.mp4

How to test

  1. Launch the example app
  2. Go to the Logos page

@dmnplb dmnplb requested review from a team as code owners March 7, 2024 11:38
@dmnplb dmnplb changed the title [IOAPPX-260] Update Avatar component, deprecate circle shape [IOAPPX-260] Update Avatar component, deprecate shape prop Mar 7, 2024
README.md Show resolved Hide resolved
@dmnplb dmnplb merged commit 87bd425 into main Mar 8, 2024
2 checks passed
@dmnplb dmnplb deleted the IOAPPX-260-update-avatar branch March 8, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants