Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-264] Disable the exiting transition in the ButtonSolid component to prevent glitch #223

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[IOAPPX-264] Disable the exiting transition in the ButtonSolid component to prevent glitch #223

merged 3 commits into from
Mar 20, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Mar 20, 2024

Short description

This PR disables the exiting transition on the inner text of the ButtonSolid to prevent a weird glitch when the component is unmounted on the exit page transition.

List of changes proposed in this pull request

  • Disable exiting transition

How to test

N/A

@dmnplb dmnplb requested review from a team as code owners March 20, 2024 11:13
shadowsheep1
shadowsheep1 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Resolve `nav.pop(n)` with `n>1` and `bottomsheet` glitches

✅
two-birds-with-one-stone.mp4

@dmnplb dmnplb merged commit b02cbbf into main Mar 20, 2024
2 checks passed
@dmnplb dmnplb deleted the IOAPPX-264-remove-exit-enter-transitions-button-solid branch March 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowsheep1 shadowsheep1 shadowsheep1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @shadowsheep1