Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-269] Fix wrong color of TextInput when experimental DS is off #228

Merged
merged 3 commits into from
Mar 27, 2024
Merged

[IOAPPX-269] Fix wrong color of TextInput when experimental DS is off #228

merged 3 commits into from
Mar 27, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Mar 27, 2024

Short description

This PR fixes the wrong color of TextFields components when the experimental DS is disabled.

List of changes proposed in this pull request

  • Add the correct theme key value to the border
  • Change caret color on both iOS and Android

Preview

New DS off New DS on
Simulator Screenshot - iPhone 14 Pro - 2024-03-27 at 10 07 20 Simulator Screenshot - iPhone 14 Pro - 2024-03-27 at 10 07 31

How to test

  1. Launch the example app
  2. Go to the TextInputs screen

@dmnplb dmnplb added the bug Something isn't working label Mar 27, 2024
@dmnplb dmnplb requested review from a team as code owners March 27, 2024 09:10
@dmnplb dmnplb merged commit 037cb1a into main Mar 27, 2024
2 checks passed
@dmnplb dmnplb deleted the IOAPPX-269-fix-textfields-wrong-color-experimental-ds-off branch March 27, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @CrisTofani