[IOAPPX-283] Deprecate GradientScrollView for IOScrollView
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested changes
Apr 10, 2024
dmnplb
changed the title
GradientScrollViewIOScrollView, next iteration of GradientScrollView (now deprecated)
dmnplb
changed the title
IOScrollView, next iteration of GradientScrollView (now deprecated)GradientScrollView for IOScrollView
|
@CrisTofani This PR has been re-purposed to deprecate |
CrisTofani
approved these changes
May 17, 2024
dmnplb
added a commit
to pagopa/io-app
that referenced
this pull request
May 17, 2024
…dientScroll`, now deprecated) + `IOScrollViewWithLargeHeader` (#5704) > [!note] > This PR is the result of the discussion we had in the PR below: > * pagopa/io-app-design-system#243 ## Short description This PR add the new `IOScrollView`, next iteration of the `GradientScrollView` (now officially deprecated): - Simpler UI logic without unnecessary calculations - Option to add a tertiary button - Dark mode support It also adds the new `IOScrollViewWithLargeHeader` screen component that should replace `RNavScreenWithLargeHeader`. ## List of changes proposed in this pull request - Add the new `IOScrollView` screen component. Compared to the previous `GradientScrollView`: - Remove `GradientBottomActions` because it hasn't added any advantage - Add the new `snapOffset` prop to optionally configure the snap point - Add optional `headerConfig` prop - Add optional `includeContentMargins` boolean value to remove content margins if needed - Manage everything inside `GradientScrollView` (now `IOScrollView`) - Refactor action related props by adding a single `actions` config object - Change opacity transition from discrete to continuous - Apply the opacity transition just to the gradient, excluding safe background block - Improve `debugMode` so you can see the gradient area even when the end is reached - Add the new `IOScrollViewWithLargeHeader` screen component. Compared to the previous `RNavScreenWithLargeHeader`: - Remove `fixedBottomSlot` because we already manage the actions at the bottom with the `IOScrollView` component - Simpler inner component logic ### Preview | Three buttons | Debug section | |--------|--------| | <video src="https://github.com/pagopa/io-app-design-system/assets/1255491/9f9e0760-87d6-43ca-bc2c-2e3fd7f117b8"> | <video src="https://github.com/pagopa/io-app/assets/1255491/930661d8-b205-4818-89c5-dd742e3f4e78"> | | New opacity transition | Dark mode | |--------|--------| | <video src="https://github.com/pagopa/io-app-design-system/assets/1255491/ba5c0759-cc33-42fc-ac2f-26ffdd3d4293"> | <video src="https://github.com/pagopa/io-app-design-system/assets/1255491/f7d8cb29-d0a4-42b1-b7df-ed3efe4e8494"> | As you can see from the video above, in the most extreme case you can see all kinds of buttons. ## How to test 1. Launch the app in the local environment 2. Go to the **Design System → Screens → IOScrollView…** screens --------- Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Alice Di Rico <[email protected]> Co-authored-by: Mario Perrotta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This PR depends on:
IOScrollView(next iteration ofGradientScroll, now deprecated) +IOScrollViewWithLargeHeaderio-app#5704Short description
This PR deprecates the
GradientScrollandGradientBottomActionscomponents.Important
This PR was added as part of the refactoring of the
GradientScrollcomponent, but we preferred to move the screen component to the main repo for easier maintenance.To learn more about the new
IOScrollViewcomponent, please refer to:IOScrollView(next iteration ofGradientScroll, now deprecated) +IOScrollViewWithLargeHeaderio-app#5704List of changes proposed in this pull request
GradientScrollandGradientBottomActionscomponentsHow to test
N/A