Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [PE-578] Add new variant to the Tag component #255

Merged
merged 1 commit into from
May 2, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 2, 2024

Short description

This PR adds a new Tag variant that allows the passing of custom icon props such as icon name and icon color, making this component more flexible and dynamic as showed in the following case: https://www.figma.com/file/yOoBGDr1MJpa0LY5lDUFSd/IOapp_CartaGiovaniNazionale?type=design&node-id=4405-100552&mode=design&t=YXJlUj57xQtDYAm8-4

List of changes proposed in this pull request

  • Added a new variant name customIcon
  • Added a new prop customIconProps which is required when the variant is customIcon

Preview

image

@Hantex9 Hantex9 requested review from dmnplb and a team as code owners May 2, 2024 09:17
@Hantex9 Hantex9 merged commit ff81703 into main May 2, 2024
6 checks passed
@Hantex9 Hantex9 deleted the PE-578-adapt-tag-variant branch May 2, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants