Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-641] Add ListItemHeader a11y role as heading #268

Merged
merged 1 commit into from
May 21, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 21, 2024

Short description

This PR adds the header role to the label of the ListItemHeader component.

List of changes proposed in this pull request

  • Added role attribute to the H6 component that wraps the label

How to test

With the voice over active, you should be able to hear the heading role while tapping on it.

@Hantex9 Hantex9 added the a11y label May 21, 2024
@Hantex9 Hantex9 requested review from dmnplb and a team as code owners May 21, 2024 08:18
@Hantex9 Hantex9 changed the title chore: [IOBP-641] Add ListItemInfo a11y role as heading chore: [IOBP-641] Add ListItemHeader a11y role as heading May 21, 2024
@Hantex9 Hantex9 merged commit aa43183 into main May 21, 2024
6 checks passed
@Hantex9 Hantex9 deleted the IOBP-641-add-list-item-header-role branch May 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants