[IOPID-1531] fix radio button accessibility on android #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
approved these changes
Jun 5, 2024
Ladirico
added a commit
to pagopa/io-app
that referenced
this pull request
Jun 5, 2024
…5823) > [!Important] > This PR depends on pagopa/io-app-design-system#278 ## Short description Add new DS on language preferences screen ## List of changes proposed in this pull request - Change copy - Integrate new DS - Delete logic to show banner (always visible) - Add unit test - Change component from class to function - update DS library version (to apply the fix on accessibility) - Add logic to show/hide banner from remote ## Demo <p> | 🍏 iOS 🍏 | 🤖 Android 🤖 | | - | - | | <video src="https://github.com/pagopa/io-app/assets/83651704/1c5b5a77-ae1d-4057-bac7-c040325f9b1f"/> | <video src="https://github.com/pagopa/io-app/assets/83651704/fc949eb8-a63a-4f36-b582-f89bb5558a2d"/> | </p> ## A11Y <p> | 🍏 iOS 🍏 | 🤖 Android 🤖 | 🤖 Android NEW (applying the change on DS) 🤖 | - | - | - | | <video src="https://github.com/pagopa/io-app/assets/83651704/1f119a94-b9e1-4841-9237-32899f5a3e03"/> | <video src="https://github.com/pagopa/io-app/assets/83651704/bb14eb40-9cfd-4bad-9a04-3f27dbd29a70"/> | <video src="https://github.com/pagopa/io-app/assets/83651704/5474e622-b338-41e0-a1d9-95a8cdac3dd0"/> | </p> ## How to test Run the application and navigate in _profile section > preferences > language_ > [!Note] > To simulate error i've use **Proxyman** --------- Co-authored-by: ChrisMattew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
add
importantForAccessibility="no-hide-descendants"to read correctly on Android the accessibility labelDEMO A11Y
Important
On iOS the accessibility was read correctly and there was no regression, so there is no video
android_a11y_lang.mp4
android_a11y_lang_new.mp4