[IOPID-1899] NumberPad optimization
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMattew
added
documentation
shadowsheep1
reviewed
Jun 7, 2024
dmnplb
changed the title
NumberPad optimization
dmnplb
approved these changes
Jun 10, 2024
shadowsheep1
added a commit
to pagopa/io-app
that referenced
this pull request
Jun 13, 2024
> [!warning] > This PR depends on pagopa/io-app-design-system#284 ## Short description Upgraded DS lib and adapted all components that use `NumberPad` component. ## List of changes proposed in this pull request - Upgraded DS lib. - Adapted all those components<sup>*</sup> that use the `NumberPad` component to its new implementation derived from this DS update. - Some performance improvements in the `PinCreation` components, replaced the `pinMode` state with the `pinModeRef` to avoid renders on pin mode change. >[!Note] ><sup>*</sup> The affected components are: `IdentificationNumberPad`, `PinCreation` and `DSNumberPad` ## E2E Tests >[!Tip] >[](https://github.com/pagopa/io-app/actions/workflows/test-e2e.yml) ## Screens <details><summary>iOS</summary> <p> |Identification Modal|Pin Creation|DS NumberPad| |-|-|-| |<video src="https://github.com/pagopa/io-app/assets/94987118/ceaaa7fa-842e-41ae-b0e3-f8881c7c4035" />|<video src="https://github.com/pagopa/io-app/assets/94987118/33e1edd8-8f0b-42f2-a5f3-0ed7820d8044" />|<video src="https://github.com/pagopa/io-app/assets/94987118/1bd5d7e9-3070-4ef7-8cec-5becd6413362" />| </p> </details> <details><summary>Android</summary> <p> |Identification Modal|Pin Creation|DS NumberPad| |-|-|-| |<video src="https://github.com/pagopa/io-app/assets/94987118/9f43922a-c403-41f1-8197-2bb9ebee4fa5" />|<video src="https://github.com/pagopa/io-app/assets/94987118/556bae2b-b482-42e4-a8d9-0bee24a9083a" />|<video src="https://github.com/pagopa/io-app/assets/94987118/738c8061-cb34-4bdd-ad25-cb9701404eb1" />| </p> </details> ## How to test Since there are three components affected by this changes, there are just as many tests: - **DSNumberPad**: Navigate to `Profile > Design System` and under Screens section tap on `NumberPad` list item. - **IdentificationNumberPad**: This component belongs to `IdentificationModal` component so it can be tested doing any operation that requires identification. - **PinCreation**: Follow the *How to test* section in this [PR](#5737) --------- Co-authored-by: Fabio Bombardi <[email protected]>
](https://github.com/pagopa/io-app/actions/workflows/test-e2e.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Improved
NumberPadcomponent performance, avoiding unnecessary rendersList of changes proposed in this pull request
NumberPadcomponentNumberPadandNumberButtoncomponentsNumberPadAPIs and logic**Important
** The pin concatenation is not handled by
NumberPadanymore. This kind of logic will need to be handled directly where the component will be used.How to test
Run the
ExampleApp, navigate in theComponents > NumberPadsection and start typing.