[IOAPPX-326] Fix bug on Android when using SemiBold font weight
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
changed the title
Semibold font weightSemiBold font weight
adelloste
approved these changes
Jun 19, 2024
dmnplb
added a commit
to pagopa/io-app
that referenced
this pull request
Jun 20, 2024
…t weight (#5878) > [!warning] > This PR depends on: > * pagopa/io-app-design-system#293 ## Short description This PR fixes a **critical** UI bug on Android when using the `SemiBold` font weight. The new _**Titillium Sans Pro**_ uses `Semibold` as a font attribute, while the previous _**Titillium Web**_ fonts used `SemiBold`. Android didn't handle this edge case and rendered everything with the fallback system font. ## List of changes proposed in this pull request - Replace `SemiBold` font weight attribute with `Semibold` in all the typographic styles ## How to test 1. Launch the app with an Android physical or virtual device 2. Check **Typography** screen or everything else in the app --------- Co-authored-by: Cristiano Tofani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR fixes a critical UI bug on Android when using the
SemiBoldfont weight. The new Titillium Sans Pro usesSemiboldas a font attribute, while the previous Titillium Web fonts usedSemiBold. Android didn't handle this edge case and rendered everything with the fallback system font.List of changes proposed in this pull request
SemiBoldfont weight attribute withSemiboldin all the typographic stylesMDH2with a different font size to distinguish it fromMDH3How to test