Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-2011] integrate setting pictogram #308

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Jul 10, 2024

Short description

This PR introduces the PictogramSettings and PictogramBleedSettings pictograms.

Screenshot 2024-07-10 alle 12 45 01

How to test

Within the example app, navigate to the Pictograms section and check that the new pictograms are correctly rendered

@Ladirico Ladirico requested review from dmnplb and CrisTofani July 10, 2024 10:46
@Ladirico Ladirico self-assigned this Jul 10, 2024
@Ladirico Ladirico requested review from a team as code owners July 10, 2024 10:46
@Ladirico Ladirico changed the title Iopid 2011 integrate setting icon [IOPID-2011] integrate setting icon Jul 10, 2024
Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pictogram you need is part of the Bleed group. In general when we have a new pictogram, there are two versions:

  • Standard (the one you can see in the bigger blocks in the Pictograms screen)
  • Bleed (the one you can see in the smaller blocks below, in the same screen)

If we follow this file organization, the exported pictogram should be named PictogramBleedSettings. And the standard should have the filename PictogramSettings.

Everything is already explained in this document.

tldr: just export from Figma PictogramSettings.svg and PictogramBleedSettings.svg, place them in the svg/originals folder and run the command yarn generate:pictograms. Remember to add the keys to the Pictograms object and relative Bleed subobject.

@Ladirico
Copy link
Contributor Author

The pictogram you need is part of the Bleed group. In general when we have a new pictogram, there are two versions:

  • Standard (the one you can see in the bigger blocks in the Pictograms screen)
  • Bleed (the one you can see in the smaller blocks below, in the same screen)

If we follow this file organization, the exported pictogram should be named PictogramBleedSettings. And the standard should have the filename PictogramSettings.

Everything is already explained in this document.

tldr: just export from Figma PictogramSettings.svg and PictogramBleedSettings.svg, place them in the svg/originals folder and run the command yarn generate:pictograms. Remember to add the keys to the Pictograms object and relative Bleed subobject.

Thanks for the correction. I have made a new push with the corrections! @dmnplb

@Ladirico Ladirico changed the title [IOPID-2011] integrate setting icon [IOPID-2011] integrate setting pictogram Jul 10, 2024
@Ladirico Ladirico requested a review from dmnplb July 10, 2024 12:30
@Ladirico Ladirico merged commit e919e4a into main Jul 10, 2024
6 checks passed
@Ladirico Ladirico deleted the IOPID-2011-integrate-setting-icon branch July 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants