-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOPID-2011] integrate setting pictogram #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pictogram you need is part of the Bleed
group. In general when we have a new pictogram, there are two versions:
- Standard (the one you can see in the bigger blocks in the Pictograms screen)
- Bleed (the one you can see in the smaller blocks below, in the same screen)
If we follow this file organization, the exported pictogram should be named PictogramBleedSettings
. And the standard should have the filename PictogramSettings
.
Everything is already explained in this document.
tldr: just export from Figma PictogramSettings.svg
and PictogramBleedSettings.svg
, place them in the svg/originals
folder and run the command yarn generate:pictograms
. Remember to add the keys to the Pictograms
object and relative Bleed
subobject.
Thanks for the correction. I have made a new push with the corrections! @dmnplb |
Short description
This PR introduces the
PictogramSettings
andPictogramBleedSettings
pictograms.How to test
Within the example app, navigate to the Pictograms section and check that the new pictograms are correctly rendered