Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-353] Add the new FooterActions (from io-app) and FooterActionsInline #316

Merged
merged 13 commits into from
Oct 9, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Jul 25, 2024

Short description

This PR adds the new FooterActions (migrated from io-app) and the new FooterActionsInline, which replaces the legacy FooterWithButtons. So if you want to add actions to the footer you have several options:

  • If you need a single button, just use FooterActions with the SingleButton type
  • If you need two buttons, depending on your needs:
    • use FooterActions as recommended in the official guidelines
    • for special reasons (e.g. you need to save space), use FooterActionsInline to render both buttons on the same line
  • If you need three buttons, just use FooterActions with the ThreeButtons type

Both FooterActions and FooterActionsInline come with two hooks, useFooterActionsMeasurements and useFooterActionsInlineMeasurements respectively, to get the safeBottomAreaHeight value to apply to the ScrollView's paddingBottom

List of changes proposed in this pull request

  • Add the new FooterActions and FooterActionsInline and relative hooks
  • Add the new demo screens to the example app
  • Add the new IOSpacing object with the common spacing constants
  • Update the deprecation note to FooterWithButtons
  • Add the deprecation note to BlockButtons

Preview

footer-actions-inline-demo.mp4

How to test

  1. Launch the example app
  2. Go to the FooterActions… screens

@dmnplb dmnplb added the documentation Improvements or additions to documentation label Jul 25, 2024
@dmnplb dmnplb marked this pull request as ready for review July 25, 2024 14:27
@dmnplb dmnplb requested review from a team as code owners July 25, 2024 14:27
@dmnplb dmnplb merged commit ef084b2 into main Oct 9, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-353-add-footer-actions-inline branch October 9, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants