[IOAPPX-352] Add the new IO typeface #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a11y features (#312) ## Short description This PR adds the new `IOText` component, which replaces the legacy `BaseTypography` component. Compared to the previous component, `IOText` has the following features: - Built-in support for bold text, if set by the user (iOS only) - Add the new typographic attributes, like `fontSize` and `lineHeight` to the `makeFontStyleObject` function - Manage required or optional props (like `style`) with a stricter approach without using the `TypographyFactory` - Based on the new `IOFontSize` scale ## List of changes proposed in this pull request - Add the new `IOText` component - Update all the typographic styles using `IOText`, bypassing the `TypographyFactory` - Update the typographic styles with a fallback theme color to ensure built-in support for dark mode - Add the new `useBoldTextEnabled` hook - Deprecate `BaseTypography` - Remove `LabelLink` in favor of `asLink` prop for all the `Label…` and `Body` typographic styles - Add the new `LabelMini` style - Remove `MdH4`, `MdH5` and `MdH6` styles - Improve `FeatureInfo` component API ### Preview https://github.com/user-attachments/assets/a15bc7f5-9e93-4326-b427-501ed9edf1b0 ### Co-authors @CrisTofani ## How to test N/A --------- Co-authored-by: Cristiano Tofani <[email protected]>
…plete of `IOText` when using `font` prop (#322) ## Short description This PR fixes a number of issues that were encountered when adding `IOText` to the main repo ## List of changes proposed in this pull request - Set `Label…` default weight to `Semibold`, instead of `Bold` → 13819ba - Fix wrong autocomplete of `IOText` when using `font` prop → 6f1496c - Update `Label…` snapshots → 0ffdfcd ## How to test N/A
> [!note] > This PR depends on: > * #312 ## Short description This PR adds the new IO typeface (temporarily named **Titillio**). This change is visible only if experimental DS is on. ## List of changes proposed in this pull request - Add the new `Titillio` typeface and relative font files - Remove references to `ReadexPro` ### Preview https://github.com/user-attachments/assets/eb1820dc-1f82-49e9-9218-1a2430ed6477 ## How to test 1. Run the example app 2. Enable experimental DS and check every screen --------- Co-authored-by: Cristiano Tofani <[email protected]>
This PR reverts #314 to avoid a `2.0.0` release that includes the reference to the new `IO` typeface
CrisTofani
approved these changes
Nov 11, 2024
dmnplb
added a commit
to pagopa/io-app
that referenced
this pull request
Nov 11, 2024
…` typeface ✨ (#6319) ## Short description This PR replaces the `ReadexPro` with the new custom typeface `Titillio`. ## List of changes proposed in this pull request - Remove `ReadexPro` folder - Update `react-native-config` references to the new font - Remove `LabelSmallAlt`, because it's replaceable with the `LabelSmall` - Update `io-app-design-system` to `2.1.0` - Update `reanimated` version to `3.15.0` ### Related PR * pagopa/io-app-design-system#334 ## How to test Launch the app, browse some sections and check if everything is OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the new IO Titillio typeface. This change is visible only if experimental DS is on.
List of changes proposed in this pull request
Titilliotypeface and relative font filesReadexProPreview
To watch a video reference (relative to a past iteration), please refer to the original PR:
How to test