[IOAPPX-411] Increase contrast of CodeInput and OTPInput
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
approved these changes
Nov 8, 2024
dmnplb
added a commit
that referenced
this pull request
Nov 14, 2024
… or accent backgrounds (#357) ## Short description This PR fixes a visual regression introduced when [we increased the contrast of the `CodeInput` component](#341). ## List of changes proposed in this pull request - Change the color of the empty dot when we're using dark or accent backgrounds - Make `CodeInput` dark mode compliant ### Preview https://github.com/user-attachments/assets/d436578e-98a7-4d5a-af7a-c45950bcecaa ## How to test Go to the **Number Pad** screen in the example app. Enable/disable accent background or enable/disable dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR increases contrast of
CodeInputandOTPInput.Preview
OTPInputCodeInputHow to test
Launch the example app and check the two mentioned components