Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-412] Add dark mode support to Badge and Tag components #343

Merged
merged 11 commits into from
Nov 20, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Oct 25, 2024

Short description

This PR adds support for dark mode to the Badge and Tag components

List of changes proposed in this pull request

  • Add dark mode support for both components
  • Add a specific forceLightMode prop to Tag components to force light mode, even in dark mode, because the component is also used inside the Wallet cards, which probably won't have a dark mode version in the near future

Preview

How to test

Launch the example app and check every component in the Badges & Tags

@dmnplb dmnplb requested review from a team as code owners October 25, 2024 12:29
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested positively

Dark Light
Screenshot 2024-11-20 at 18 00 54 Screenshot 2024-11-20 at 18 01 19

@dmnplb dmnplb merged commit 4bf1a32 into main Nov 20, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-412-add-dark-mode-badge branch November 20, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants