-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOPID-2426] Tooltip component #351
Conversation
…behaviors in ScrollView elements
Awesome! Why don't we add a very subtle fade in \ fade out transition to gently darken the background? @dmnplb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @thisisjp rightly points out, the component feels a bit static in terms of interaction: we could improve both the background and the entry/exit transitions. But I also want to be pragmatic: I think that the first iteration is good enough to release.
Let's not forget that this component is special because it needs to handle different placements and device configurations, so we should integrate it into the main app as soon as possible to do the appropriate viability tests before making any other improvements.
So, in short: LGTM, but let's plan the following refinements:
- Background and entry/exit smooth transitions, ideally made with
reanimated
- Dark mode support by using the appropriate theme keys
Co-authored-by: Alice Di Rico <[email protected]>
Co-authored-by: Alice Di Rico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR adds the
Tooltip
componentList of changes proposed in this pull request
Tooltip
componentTooltips
screen in the Example app to show theTooltip
behaviorsDemo
tooltips-demo.mp4
android-tooltip.mp4
a11y-iOS-tooltip.MP4
a11y-android-tooltip.mp4
Important
The
left
andright
positions are calculated after the component is rendered. This implementation causes a minor glitch where the Tooltip repositions itself to achieve a centered alignment relative to the enclosing element.To avoid this behavior, the opacity value of the component depends on the parameters returned by the
onLayout
prop. Once thetooltipLayout
is defined, the opacity is set to a value of 1.How to test
Run the example app and test the
Tooltip
different implementations