Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPX-449] Remove size prop from Banner #369

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Dec 17, 2024

Caution

This PR introduces a breaking change. It will be merged along with this PR just before we release the 5.0.0 major:

Short description

This PR removes the size prop from the Banner component

List of changes proposed in this pull request

  • Remove size prop
  • Update documentation in the example app
  • Update story for Storybook

@dmnplb dmnplb requested review from a team as code owners December 17, 2024 08:58
@dmnplb dmnplb changed the base branch from main to 5.x January 8, 2025 14:46
@dmnplb dmnplb merged commit 04e0cd4 into 5.x Jan 8, 2025
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-449-remove-size-prop-banner branch January 8, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants