Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPX-456] Improve ListItemNav and ListItemTransaction dynamic spacing #373

Merged
merged 5 commits into from
Dec 20, 2024
Merged

[IOAPPX-456] Improve ListItemNav and ListItemTransaction dynamic spacing #373

merged 5 commits into from
Dec 20, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Dec 19, 2024

Short description

This PR improves ListItemNav and ListItemTransaction dynamic spacing after testing the components with larger text in the following PR:

List of changes proposed in this pull request

  • Remove extra space before chevron in the ListItemNav
  • Disable dynamic spacing in the ListItemTransaction between amount and chevron

How to test

N/A

@dmnplb dmnplb requested review from a team as code owners December 19, 2024 16:40
@dmnplb dmnplb mentioned this pull request Dec 20, 2024
Merged
LeleDallas
LeleDallas approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Screenshot 2024-12-20 at 10 19 11

@dmnplb dmnplb merged commit 1c31558 into main Dec 20, 2024
6 checks passed
@dmnplb dmnplb deleted the IOAPPX-456-improve-list-item-dynamic-spacing branch December 20, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeleDallas LeleDallas LeleDallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @LeleDallas