Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the entering transition on the first render of ButtonSolid #374

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Dec 20, 2024

Short description

This PR adds a skip of the entering transition on the first render of ButtonSolid

List of changes proposed in this pull request

  • Restore previous code to avoid entering transition

Preview

The entering transition in the first render we'd like to remove (play at 0.25/0.5×)

entering-transition.mp4

How to test

Go to the Buttons page in the example app and check if there's any difference between main and this branch

@dmnplb dmnplb requested review from a team as code owners December 20, 2024 11:10
@dmnplb dmnplb merged commit a2b813e into main Dec 20, 2024
6 checks passed
@dmnplb dmnplb deleted the disable-entering-transition-first-render branch December 20, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants