Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIW-1978] Fix a11y issues of list item header and action element #380

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Jan 13, 2025

Short description

This PR modifies the accessibility props of ListItemHeader to fix how the header is announced. To be more specific:

  • The header label is announced independently as a header;
  • The optional action item on the right is announced with its own accessibility label, without the header label.

List of changes proposed in this pull request

  • Made the header view accessible with role header
  • Removed accessibility from the outer component view
  • Removed concatenation of header label and action label

How to test

Use a screen reader to announce the list item header, with and without the end element. Ensure each part is announced correctly, in the right order.

@gispada gispada requested review from dmnplb and a team as code owners January 13, 2025 15:53
@dmnplb
Copy link
Collaborator

dmnplb commented Jan 15, 2025

@gispada Have you already tested the accessibility on both iOS and Android? If so, have you tested on a real physical device or a virtual one?

@gispada
Copy link
Collaborator Author

gispada commented Jan 15, 2025

I tested on both platforms on a real device.

@dmnplb dmnplb merged commit 0a63a9f into main Jan 15, 2025
6 checks passed
@dmnplb dmnplb deleted the SIW-1978-list-item-header-a11y-fix branch January 15, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants