Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPLT-64] Migrating typography components from io-app #4

Merged
merged 4 commits into from
Jul 4, 2023
Merged

[IOPLT-64] Migrating typography components from io-app #4

merged 4 commits into from
Jul 4, 2023

Conversation

drmarro
Copy link
Contributor

@drmarro drmarro commented Jul 3, 2023

Short description

Migrating all the typography components from the io-app.

List of changes proposed in this pull request

  • BaseTypograhy
  • Body
  • Factory
  • H1
  • H2
  • H3
  • H4
  • H5
  • H6
  • Label
  • LabelSmall
  • Link
  • Monospace

@drmarro drmarro requested review from dmnplb, CrisTofani and a team July 3, 2023 14:13
CrisTofani
CrisTofani requested changes Jul 3, 2023
View reviewed changes
src/components/typography/H4.tsx Outdated Show resolved Hide resolved
@drmarro drmarro requested a review from CrisTofani July 4, 2023 07:18
CrisTofani
CrisTofani approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drmarro drmarro merged commit 0967720 into main Jul 4, 2023
@drmarro drmarro deleted the IOPLT-64-migrating-typography branch July 4, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

@dmnplb dmnplb Awaiting requested review from dmnplb dmnplb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drmarro @CrisTofani