IOPLT-137 Introducing storybook #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
requested changes
Aug 31, 2023
dmnplb
reviewed
Sep 1, 2023
Comment on lines
+59
to
+65
| /* @font-face { | ||
| font-family: 'TitilliumWeb'; | ||
| src: url('../fonts/TitilliumWeb/TitilliumWeb-Black.ttf') format("truetype"); | ||
| font-weight: 400; | ||
| font-style: normal; | ||
| color: black; | ||
| } */ |
There was a problem hiding this comment.
Suggested change
| /* @font-face { | |
| font-family: 'TitilliumWeb'; | |
| src: url('../fonts/TitilliumWeb/TitilliumWeb-Black.ttf') format("truetype"); | |
| font-weight: 400; | |
| font-style: normal; | |
| color: black; | |
| } */ |
We don't use Black weight in the app, so we could easily delete it.
dmnplb
approved these changes
Sep 1, 2023
CrisTofani
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Introducing storybook for the DS.
The current implementation provides a basic structure with the typography and ButtonSolid components.
List of changes proposed in this pull request
How to test
Run "yarn storybook" to launch storybook on you local env.