[IOAPPFD0-168] Enable font scaling for the Button… components
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
reviewed
Oct 4, 2023
| @@ -54,7 +54,7 @@ export const BaseTypography: React.FC<OwnProps> = props => { | |||
| : [props.fontStyle, fontStyle]; | |||
|
|
|||
| return ( | |||
| <Text {...props} style={style}> | |||
| <Text allowFontScaling={false} {...props} style={style}> | |||
There was a problem hiding this comment.
what about wiring this to the experimental context too?
There was a problem hiding this comment.
Note that io-app has a default prop with allowFontScaling set to false. So it's kind of a redundant prop for proper testing in the example app.
CrisTofani
approved these changes
Oct 4, 2023
|
what a time to be alive <3 thanks guys, let's keep up the good work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR enables font scaling for the
Button...components only when the experimental DS is enabled.List of changes proposed in this pull request
ButtonSolid,ButtonOutlineandButtonLinkcomponentsPreview
How to test