Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOAPPFD0-171] Add the new LoadingSpinner component #97

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Oct 6, 2023

Short description

This PR adds the new LoadingSpinner component, derived from ItwLoadingSpinner developed specifically for the IT Wallet flow. To learn more about the original component:

List of changes proposed in this pull request

  • Slightly refactor the original component
  • Add the new Loaders page to the example app

Preview

loading-spinner.mp4

How to test

  1. Launch the example app
  2. Go to the Loaders page

@dmnplb dmnplb requested review from a team as code owners October 6, 2023 12:25
@LazyAfternoons
Copy link
Contributor

LazyAfternoons commented Oct 6, 2023

I just want to leave a comment regarding this loader. The version implemented here is temporary as the actual loading indicator has a gradient:
Screenshot 2023-10-06 at 15 20 35

Unfortunately we couldn't implement it yet.

@dmnplb
Copy link
Collaborator Author

dmnplb commented Oct 6, 2023

@LazyAfternoons Yes, I'm aware of the difference. But we could still release it with the prospect of refining it later. Also we're going to change the following things:

  • Leave only one prop (foregroundColor or just color) without the need to set the backgroundColor
  • Probably rewrite using Reanimated instead of Animated (low priority)

@dmnplb
Copy link
Collaborator Author

dmnplb commented Oct 9, 2023

@LazyAfternoons Improved it by making it look like the designed one. It doesn't use the border hack anymore, but everything is made with a custom SVG. To summarize everything:

  • there is only one color prop, so we don't need to set backgroundColor anymore
  • you can also set a custom stroke value

@CrisTofani Fixed the TS issue with the new page by deleting it. YOLO.

@LazyAfternoons
Copy link
Contributor

LazyAfternoons commented Oct 9, 2023

@LazyAfternoons Improved it by making it look like the designed one. It doesn't use the border hack anymore, but everything is made with a custom SVG. To summarize everything:

  • there is only one color prop, so we don't need to set backgroundColor anymore
  • you can also set a custom stroke value

@CrisTofani Fixed the TS issue with the new page by deleting it. YOLO.

Thank you, it looks good to me. I think the Loaders page is missing from the example app though. Is it missing due to the TS issue you mentioned?

@dmnplb
Copy link
Collaborator Author

dmnplb commented Oct 9, 2023

I think the Loaders page is missing from the example app though. Is it missing due to the TS issue you mentioned?

Yes, it's missing because we have a TS issue when we add the new page. But it's a minor issue because the official DS page will be in the official repository

@dmnplb dmnplb merged commit 0ef2d37 into main Oct 9, 2023
@dmnplb dmnplb deleted the IOAPPFD0-171-loading-spinner branch October 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants