Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPFD0-134] Add the new AccordionItem to the Design System playground #4938

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Aug 29, 2023

Short description

This PR adds the new AccordionItem to the relative Design System page. The new component accepts two types of content: a string or a React node

To learn more about the component, please read the original PR:

List of changes proposed in this pull request

  • Add the new AccordionItem to the DSAccordion component

Preview

newAccordionItem.mp4

How to test

Go to the Profile → Design System → Accordion (Components)

@dmnplb dmnplb requested a review from a team as a code owner August 29, 2023 14:56
@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Aug 29, 2023
@dmnplb dmnplb temporarily deployed to dev August 29, 2023 15:00 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPFD0-134] Add the new AccordionItem to the Design System playground chore: [IOAPPFD0-134] Add the new AccordionItem to the Design System playground Aug 29, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 29, 2023

Affected stories

Generated by 🚫 dangerJS against 260eaa9

@dmnplb dmnplb temporarily deployed to dev August 29, 2023 16:12 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev August 31, 2023 09:22 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev August 31, 2023 10:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4938 (f47978e) into master (260c0a7) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

❗ Current head f47978e differs from pull request most recent head 260eaa9. Consider uploading reports for the commit 260eaa9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4938      +/-   ##
==========================================
- Coverage   47.17%   47.17%   -0.01%     
==========================================
  Files        1632     1632              
  Lines       32012    32022      +10     
  Branches     8052     8052              
==========================================
+ Hits        15103    15105       +2     
- Misses      16849    16857       +8     
  Partials       60       60              
Files Changed Coverage Δ
ts/features/design-system/core/DSAccordion.tsx 25.00% <25.00%> (-25.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260c0a7...260eaa9. Read the comment docs.

@dmnplb dmnplb merged commit b9e0768 into master Aug 31, 2023
@dmnplb dmnplb deleted the IOAPPFD0-134-add-accordion-ds branch August 31, 2023 12:58
Ladirico pushed a commit that referenced this pull request Sep 5, 2023
…m playground (#4938)

## Short description
This PR adds the new `AccordionItem` to the relative Design System page.
The new component accepts two types of content: a `string` or a `React
node`

To learn more about the component, please read the original PR:
- pagopa/io-app-design-system#43

## List of changes proposed in this pull request
- Add the new `AccordionItem` to the `DSAccordion` component

### Preview

https://github.com/pagopa/io-app/assets/1255491/ec8eb1b8-ed01-4050-838a-850a9052dcb4

## How to test
Go to the **Profile → Design System → Accordion (Components)**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants