Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-555] Replace FullReceivedNotification with the autogenerated one #5024

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

adelloste
Copy link
Member

Short description

This PR replaces the FullReceivedNotification type with the autogenerated one.

List of changes proposed in this pull request

  • updated definitions
  • replaced the FullReceivedNotification with the autogenerated IOReceivedNotification.

How to test

run the tests and verify that everything works

@adelloste adelloste requested a review from a team as a code owner September 26, 2023 14:50
@adelloste adelloste temporarily deployed to dev September 26, 2023 14:50 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-555] Replace FullReceivedNotification with the autogenerated one feat: [IOCOM-555] Replace FullReceivedNotification with the autogenerated one Sep 26, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 26, 2023

Affected stories

  • 🌟 IOCOM-555: [APP] Aggiornare la specifica della FullReceivedNotification con la specifica autogenerata
    subtask of
    • IOCOM-91: Integrazione Piattaforma Notifiche Fase 2

Generated by 🚫 dangerJS against 995c864

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #5024 (001b261) into master (ede3abe) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 001b261 differs from pull request most recent head 995c864. Consider uploading reports for the commit 995c864 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5024      +/-   ##
==========================================
- Coverage   47.50%   47.46%   -0.04%     
==========================================
  Files        1513     1512       -1     
  Lines       31612    31591      -21     
  Branches     8022     8022              
==========================================
- Hits        15018    14996      -22     
- Misses      16531    16532       +1     
  Partials       63       63              
Files Coverage Δ
ts/features/pn/analytics/index.ts 21.31% <ø> (ø)
.../features/pn/components/LegacyPnMessageDetails.tsx 3.50% <ø> (ø)
ts/features/pn/components/PnMessageDetails.tsx 60.00% <ø> (ø)
ts/features/pn/components/PnMessagePayment.tsx 91.66% <ø> (ø)
...atures/pn/screens/LegacyPnMessageDetailsScreen.tsx 5.40% <ø> (ø)
ts/features/pn/screens/PnMessageDetailsScreen.tsx 5.40% <ø> (ø)
ts/features/pn/utils/rptId.ts 25.00% <ø> (ø)
ts/features/pn/utils/index.ts 59.09% <0.00%> (ø)
ts/features/pn/store/types/transformers.ts 25.00% <0.00%> (-8.34%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8343bc3...995c864. Read the comment docs.

@Vangaorth Vangaorth temporarily deployed to dev September 26, 2023 15:49 — with GitHub Actions Inactive
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste temporarily deployed to dev September 26, 2023 21:01 — with GitHub Actions Inactive
@adelloste adelloste merged commit 1ff4c91 into master Sep 26, 2023
@adelloste adelloste deleted the IOCOM-555 branch September 26, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants