Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPFD0-167] Add the new LogoPaymentCard component to the Design System #5077

Merged
merged 19 commits into from
Oct 17, 2023

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Oct 5, 2023

Short description

This PR adds the documentation of the LogoPaymentCard to the Logos DS page. To learn more, see the related PR:

List of changes proposed in this pull request

  • Update io-app-design-system to the 1.12.0
  • Add LogoPaymentCard to the relative DS page
  • Update DSComponentViewerBox and DSLogoPaymentViewerBox components to improve logo visualisation of the above component

Preview

How to test

Go to the Profile → Design System → Logos

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Oct 5, 2023
@dmnplb dmnplb requested a review from a team as a code owner October 5, 2023 10:44
@dmnplb dmnplb temporarily deployed to dev October 5, 2023 10:44 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPFD0-167] Add the new LogoPaymentCard component to the Design System chore: [IOAPPFD0-167] Add the new LogoPaymentCard component to the Design System Oct 5, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 5, 2023

Affected stories

Generated by 🚫 dangerJS against dea6415

@dmnplb dmnplb temporarily deployed to dev October 5, 2023 12:30 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 5, 2023 12:55 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #5077 (a2f1d23) into master (48d40c7) will decrease coverage by 0.01%.
The diff coverage is 11.11%.

❗ Current head a2f1d23 differs from pull request most recent head dea6415. Consider uploading reports for the commit dea6415 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5077      +/-   ##
==========================================
- Coverage   47.87%   47.87%   -0.01%     
==========================================
  Files        1525     1525              
  Lines       31477    31475       -2     
  Branches     7805     7806       +1     
==========================================
- Hits        15071    15070       -1     
  Misses      16358    16358              
+ Partials       48       47       -1     
Files Coverage Δ
ts/features/design-system/core/DSLogos.tsx 36.00% <33.33%> (-0.37%) ⬇️
.../design-system/components/DSComponentViewerBox.tsx 13.33% <0.00%> (-2.06%) ⬇️
...esign-system/components/DSLogoPaymentViewerBox.tsx 33.33% <0.00%> (-11.12%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d40c7...dea6415. Read the comment docs.

@dmnplb dmnplb temporarily deployed to dev October 5, 2023 14:49 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 6, 2023 08:06 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 6, 2023 08:31 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 6, 2023 08:51 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 9, 2023 07:23 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 10, 2023 09:16 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 10, 2023 09:44 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 10, 2023 12:14 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 10, 2023 14:43 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 10, 2023 20:31 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 07:15 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 14:24 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 15:53 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 16, 2023 11:51 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 17, 2023 09:13 — with GitHub Actions Inactive
@dmnplb dmnplb merged commit b1e0585 into master Oct 17, 2023
@dmnplb dmnplb deleted the IOAPPFD0-167-add-logo-payment-card branch October 17, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants