Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-610] Add the new ModuleAttachment component #5101

Merged
merged 9 commits into from
Oct 13, 2023

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented Oct 11, 2023

Short description

This PR adds the new ModuleAttachment, a component that is going to be used in the detail of a message.

Note: It's in line with the guidelines of the old design.

Preview

ModuleAttachment

List of changes proposed in this pull request

  • Added ModuleAttachment
  • Updated the Modules section

How to test

Go to the Profile → Design System → Modules

@adelloste adelloste requested review from dmnplb and a team as code owners October 11, 2023 13:49
@adelloste adelloste temporarily deployed to dev October 11, 2023 13:49 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-610] Add the new ModuleAttachment component feat: [IOCOM-610] Add the new ModuleAttachment component Oct 11, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 11, 2023

Affected stories

  • 🌟 IOCOM-610: [APP] Realizzare il componente ModuleAttachment
    subtask of
    • 🌟 IOCOM-416: [APP] Realizzare la UI dei Modelli F24

Generated by 🚫 dangerJS against 54036cd

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #5101 (ca897eb) into master (1cee8ce) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 20.45%.

❗ Current head ca897eb differs from pull request most recent head 54036cd. Consider uploading reports for the commit 54036cd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5101      +/-   ##
==========================================
- Coverage   47.92%   47.88%   -0.04%     
==========================================
  Files        1523     1524       +1     
  Lines       31410    31454      +44     
  Branches     7787     7797      +10     
==========================================
+ Hits        15053    15062       +9     
- Misses      16309    16344      +35     
  Partials       48       48              
Files Coverage Δ
ts/screens/messages/MessageRouterScreen.tsx 5.97% <ø> (ø)
ts/features/design-system/core/DSModules.tsx 40.00% <50.00%> (+1.11%) ⬆️
ts/components/ModuleAttachment.tsx 19.04% <19.04%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6d343...54036cd. Read the comment docs.

@adelloste adelloste temporarily deployed to dev October 11, 2023 17:33 — with GitHub Actions Inactive
@adelloste adelloste temporarily deployed to dev October 11, 2023 18:00 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 12, 2023 07:51 — with GitHub Actions Inactive
ts/components/ModuleAttachment.tsx Outdated Show resolved Hide resolved
@adelloste adelloste temporarily deployed to dev October 12, 2023 09:19 — with GitHub Actions Inactive
@adelloste adelloste temporarily deployed to dev October 12, 2023 09:21 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 12, 2023 12:51 — with GitHub Actions Inactive
@Vangaorth Vangaorth temporarily deployed to dev October 13, 2023 14:11 — with GitHub Actions Inactive
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste temporarily deployed to dev October 13, 2023 14:26 — with GitHub Actions Inactive
@adelloste adelloste merged commit 3606446 into master Oct 13, 2023
@adelloste adelloste deleted the IOCOM-610-module-attachment branch October 13, 2023 14:46
forrest57 pushed a commit that referenced this pull request Oct 16, 2023
## Short description
This PR adds the new `ModuleAttachment`, a component that is going to be
used in the detail of a message.

_Note_: It's in line with the guidelines of the old design.

### Preview

| ModuleAttachment |
| --- |
| <img
src="https://github.com/pagopa/io-app/assets/29163287/400b06eb-1c9b-44b6-b08f-1fc50ee16231"
width="300" /> |

## List of changes proposed in this pull request
- Added `ModuleAttachment`
- Updated the Modules section

## How to test
Go to the **_Profile → Design System → Modules_**

---------

Co-authored-by: Damiano Plebani <[email protected]>
Co-authored-by: Andrea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System New visual language and reduction of previous UI clutter IO-Comunicazione
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants