chore: [IOBP-341] Update IDPayPaymentCodeInputScreen to use new DS components #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
reviewed
Oct 18, 2023
Comment on lines
16
to
17
| IOStyles, | ||
| IOVisualCostants |
There was a problem hiding this comment.
Can we import these from @pagopa/io-app-design-system too?
pagopa-github-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5136 +/- ##
==========================================
- Coverage 47.70% 47.70% -0.01%
==========================================
Files 1548 1548
Lines 32071 32072 +1
Branches 7915 7916 +1
==========================================
Hits 15300 15300
- Misses 16721 16722 +1
Partials 50 50
Continue to review full report in Codecov by Sentry.
|
mastro993
reviewed
Oct 19, 2023
|
There's a wrong font used in this component, but we can fix it in a different task. Please refer to IOBP-344. cc @CrisTofani |
…dpay-payment-code-input' into IOBP-341-update-textField-in-idpay-payment-code-input
…extField-in-idpay-payment-code-input
mastro993
requested changes
Oct 23, 2023
ts/features/idpay/payment/screens/IDPayPaymentCodeInputScreen.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Federico Mastrini <[email protected]>
mastro993
deleted the
IOBP-341-update-textField-in-idpay-payment-code-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
updated said screen to use new DS components
List of changes proposed in this pull request
TextInputcomponent to screenFooterWithButtonsHow to test
with the idpay flag active, navigate to an IdPay discount initiative, tap "authorize payment", navigate to the last of the three items at the bottom of the screen and make sure the page follows the design.