-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOCOM-658] Remove the F24 section on cancelled SEND message #5191
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5191 +/- ##
=======================================
Coverage 47.70% 47.70%
=======================================
Files 1548 1548
Lines 32072 32071 -1
Branches 7914 7915 +1
=======================================
Hits 15300 15300
+ Misses 16722 16721 -1
Partials 50 50
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR removes the F24 section on cancelled SEND messages
List of changes proposed in this pull request
isCancelled
to render the F24 sectionHow to test
Using
io-dev-api-server
generate a cancelled SEND message with multiple F24. Check that the F24 section is not rendered