Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-658] Remove the F24 section on cancelled SEND message #5191

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

adelloste
Copy link
Member

Short description

This PR removes the F24 section on cancelled SEND messages

List of changes proposed in this pull request

  • used isCancelled to render the F24 section

How to test

Using io-dev-api-server generate a cancelled SEND message with multiple F24. Check that the F24 section is not rendered

@adelloste adelloste requested a review from a team as a code owner November 2, 2023 17:24
@adelloste adelloste temporarily deployed to dev November 2, 2023 17:24 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-658] Remove the F24 section on cancelled SEND message feat: [IOCOM-658] Remove the F24 section on cancelled SEND message Nov 2, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 2, 2023

Affected stories

  • 🌟 IOCOM-658: [APP] Rimuovere la sezione F24 in caso di notifica è cancellata
    subtask of
    • 🌟 IOCOM-416: [APP] Realizzare la UI dei Modelli F24

Generated by 🚫 dangerJS against 4eebd87

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #5191 (f225627) into master (02ad1d2) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 16.66%.

❗ Current head f225627 differs from pull request most recent head 4eebd87. Consider uploading reports for the commit 4eebd87 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5191   +/-   ##
=======================================
  Coverage   47.70%   47.70%           
=======================================
  Files        1548     1548           
  Lines       32072    32071    -1     
  Branches     7914     7915    +1     
=======================================
  Hits        15300    15300           
+ Misses      16722    16721    -1     
  Partials       50       50           
Files Coverage Δ
ts/features/pn/components/MessageDetails.tsx 75.00% <100.00%> (ø)
...atures/pn/components/MessagePaymentBottomSheet.tsx 9.09% <ø> (+0.75%) ⬆️
ts/features/pn/components/MessagePayments.tsx 36.36% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58b66e...4eebd87. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste merged commit d664ad1 into master Nov 3, 2023
@adelloste adelloste deleted the IOCOM-658-remove-f24-section branch November 3, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants