Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPCROSS-209] Fix onboarding screens + Fix E2E test #5410

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 18, 2024

Short description

This PR restores the title and description in two onboarding screens (ShareDataScreen and ServicesPreferenceScreen) using the new component RNavScreenWithLargeHeader (also used in the profile-like screens). The PR also fixes a failed E2E test (onboarding flow). Both issues were introduced by the following PR:

List of changes proposed in this pull request

  • Update OnboardingShareDataScreen and ServicesPreferenceScreen to use the new RNavScreenWithLargeHeader
  • Update the relative navigator to show the header through react-navigation
  • Update RNavScreenWithLargeHeader to accept a custom goBack handler
  • Add the titleTestID optional prop to the RNavScreenWithLargeHeader component

How to test

  • Launch the app with the flag firstOnboarding set to true
  • Run the following E2E test: /ts/__e2e__/login.e2e.ts

@dmnplb dmnplb requested a review from a team as a code owner January 18, 2024 14:38
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPCROSS-209] Fix onboarding screens + Fix E2E test chore: [IOAPPCROSS-209] Fix onboarding screens + Fix E2E test Jan 18, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 18, 2024

Affected stories

  • ⚙️ IOAPPCROSS-209: Ripristino del test E2E in seguito all'adeguamento con nuovo DS

Generated by 🚫 dangerJS against 5235901

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b68ed9d) 47.53% compared to head (5235901) 47.53%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5410   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files        1615     1615           
  Lines       33799    33800    +1     
  Branches     8271     8272    +1     
=======================================
+ Hits        16066    16067    +1     
  Misses      17675    17675           
  Partials       58       58           
Files Coverage Δ
ts/components/ui/RNavScreenWithLargeHeader.tsx 80.00% <100.00%> (+1.05%) ⬆️
ts/hooks/useHeaderProps.tsx 76.92% <ø> (ø)
ts/navigation/OnboardingNavigator.tsx 28.57% <ø> (ø)
.../onboarding/OnboardingServicesPreferenceScreen.tsx 7.69% <ø> (ø)
ts/screens/profile/ShareDataScreen.tsx 14.28% <ø> (ø)
...s/screens/onboarding/OnboardingShareDataScreen.tsx 14.28% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b68ed9d...5235901. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit 30fe477 into master Jan 18, 2024
8 checks passed
@dmnplb dmnplb deleted the IOAPPCROSS-209-restore-e2e-test branch January 18, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants