Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-1172] Update business logic for payment reminder on a message details screen with the new DS #5613

Merged
merged 91 commits into from
Mar 29, 2024

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Mar 21, 2024

This PR depends on #5603

Short description

This PR updated the business logic for the message's payment reminder, with the new DS.

Loading Expiring Expired
Simulator Screenshot - iPhone 15 - 2024-03-21 at 19 04 35 Simulator Screenshot - iPhone 15 - 2024-03-21 at 19 04 36 Simulator Screenshot - iPhone 15 - 2024-03-21 at 19 11 07

List of changes proposed in this pull request

  • The reminder in the message details:
    • is hidden, if the message has no dueDate or no payment data
    • shows a loading status while the payment is updating
    • shows "expires on" if the payment is still payable (displaying the dueDate of the message)
    • shows "has expired on" if the payment update returns a PAA_PAGAMENTO_SCADUTO code (displaying the dueDate of the message)
    • is hidden if the payment update returns an error that is not PAA_PAGAMENTO_SCADUTO

How to test

Using the io-dev-api-server, generate a message with a payment. Check that the behaviour described above is true for each case.

Vangaorth added 30 commits March 5, 2024 12:40
# Conflicts:
#	locales/en/index.yml
#	locales/it/index.yml
#	ts/features/messages/screens/MessageDetailsScreen.tsx
#	ts/features/messages/store/reducers/__tests__/payments.test.ts
#	ts/features/messages/store/reducers/payments.ts
#	ts/features/pn/components/MessageFooter.tsx
#	ts/features/pn/components/__test__/MessageFooter.test.tsx
# Conflicts:
#	locales/en/index.yml
#	locales/it/index.yml
#	ts/features/messages/screens/MessageDetailsScreen.tsx
#	ts/features/messages/store/reducers/__tests__/payments.test.ts
#	ts/features/messages/store/reducers/payments.ts
#	ts/features/pn/components/MessageFooter.tsx
#	ts/features/pn/components/__test__/MessageFooter.test.tsx
Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test cases match and I see no problems with the implementation so LGTM!

@Vangaorth Vangaorth merged commit 2a34b40 into master Mar 29, 2024
6 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1172-remidner branch March 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants