Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [PE-550] Revamp CGN Categories/All merchants screen with new DS #5668

Merged
merged 29 commits into from
May 6, 2024

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Apr 5, 2024

Short description

This PR refactors the CGN categories and all merchants screen with to apply the new DS

List of changes proposed in this pull request

  • Refactors CgnMerchantsCategoriesSelectionScreen.tsx
  • Move code to CgnMerchantCategoriesListScreen.tsx
  • Refactors CgnMerchantsListScreen.tsx
  • Removed CGN_ROUTES.DETAILS.MERCHANTS.LIST route

How to test

Navigate to CGN details than check the list of categories and tab of merchants.

Important

Icons and TabItem style will be updated by DS package in a release after merging pagopa/io-app-design-system#236

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-04-05.at.17.00.21.mp4

@pagopa-github-bot pagopa-github-bot changed the title [PE-550] Revamp CGN Categories/All merchants screen with new DS feat: [PE-550] Revamp CGN Categories/All merchants screen with new DS Apr 5, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Apr 5, 2024

Affected stories

  • 🌟 PE-550: [FE] Revamp schermate lista categorie/esercenti
    subtask of
    • PE-511: CGN - Adeguamento flussi/schermate a nuovo DS 2.0

Generated by 🚫 dangerJS against 1868144

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 9.52381% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 48.95%. Comparing base (4f204b4) to head (1868144).
Report is 47 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5668      +/-   ##
==========================================
+ Coverage   48.42%   48.95%   +0.53%     
==========================================
  Files        1488     1589     +101     
  Lines       31617    31987     +370     
  Branches     7669     7752      +83     
==========================================
+ Hits        15311    15660     +349     
- Misses      16238    16269      +31     
+ Partials       68       58      -10     
Files Coverage Δ
ts/features/bonus/cgn/navigation/actions.ts 50.00% <ø> (ø)
ts/features/bonus/cgn/navigation/navigator.tsx 70.00% <ø> (ø)
ts/features/bonus/cgn/navigation/routes.ts 100.00% <ø> (ø)
ts/features/bonus/cgn/screens/CgnDetailScreen.tsx 14.28% <ø> (+0.33%) ⬆️
.../cgn/components/merchants/CgnMerchantsListView.tsx 9.09% <0.00%> (-3.41%) ⬇️
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 29.41% <33.33%> (+26.78%) ⬆️
...s/cgn/screens/merchants/CgnMerchantsListScreen.tsx 9.75% <0.00%> (-0.51%) ⬇️
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 3.03% <3.03%> (ø)

... and 190 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4eb1b6...1868144. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about showing all these new CGN flows and redesigns under a new feature flag? Since not only has the layout of the screens changed, but also some of the flows, it could be a problem during the work in progress and users would end up with half old flows and half new flows and it could be inconsistent.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing some tests after upgrading the io-app-design-system library, I'm facing an issue with the Tab buttons while selecting. It seems that even if it is selected, the tab button doesn't change style and it appears to be an issue of the TabItem component.

Registrazione.schermo.2024-05-06.alle.11.52.01.mov

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CrisTofani CrisTofani merged commit bd745dd into master May 6, 2024
13 checks passed
@CrisTofani CrisTofani deleted the PE-550-categories-full-merchant-list branch May 6, 2024 12:06
CrisTofani added a commit that referenced this pull request May 7, 2024
## Short description
This PR implements the new DS on CGN category detail screen.

## List of changes proposed in this pull request
- Adds the new design elements on `CgnMerchantsListByCategory`

> [!note]
> Categories list and all merchants list has been refactored on #5668

## How to test
Navigate to CGN categories and check the detail of a single category.



https://github.com/pagopa/io-app/assets/3959405/3f7e6d42-77e1-4d8d-9325-0917c55a25ad

---------

Co-authored-by: Alessandro Izzo <[email protected]>
Co-authored-by: Fabio Bombardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants