-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [PE-550] Revamp CGN Categories/All merchants screen with new DS #5668
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5668 +/- ##
==========================================
+ Coverage 48.42% 48.95% +0.53%
==========================================
Files 1488 1589 +101
Lines 31617 31987 +370
Branches 7669 7752 +83
==========================================
+ Hits 15311 15660 +349
- Misses 16238 16269 +31
+ Partials 68 58 -10
... and 190 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…opa/io-app into PE-550-categories-full-merchant-list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about showing all these new CGN flows and redesigns under a new feature flag? Since not only has the layout of the screens changed, but also some of the flows, it could be a problem during the work in progress and users would end up with half old flows and half new flows and it could be inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing some tests after upgrading the io-app-design-system
library, I'm facing an issue with the Tab buttons while selecting. It seems that even if it is selected, the tab button doesn't change style and it appears to be an issue of the TabItem
component.
Registrazione.schermo.2024-05-06.alle.11.52.01.mov
ts/features/bonus/cgn/screens/merchants/CgnMerchantsListScreen.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## Short description This PR implements the new DS on CGN category detail screen. ## List of changes proposed in this pull request - Adds the new design elements on `CgnMerchantsListByCategory` > [!note] > Categories list and all merchants list has been refactored on #5668 ## How to test Navigate to CGN categories and check the detail of a single category. https://github.com/pagopa/io-app/assets/3959405/3f7e6d42-77e1-4d8d-9325-0917c55a25ad --------- Co-authored-by: Alessandro Izzo <[email protected]> Co-authored-by: Fabio Bombardi <[email protected]>
Short description
This PR refactors the CGN categories and all merchants screen with to apply the new DS
List of changes proposed in this pull request
CgnMerchantsCategoriesSelectionScreen.tsx
CgnMerchantCategoriesListScreen.tsx
CgnMerchantsListScreen.tsx
CGN_ROUTES.DETAILS.MERCHANTS.LIST
routeHow to test
Navigate to CGN details than check the list of categories and tab of merchants.
Important
Icons
andTabItem
style will be updated by DS package in a release after merging pagopa/io-app-design-system#236Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-04-05.at.17.00.21.mp4