chore(Cross): [IOAPPX-362,IOAPPX-364] Replace TypographyFactory with IOText + Add support for Bold Text a11y setting
#6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
a11y
pagopa-github-bot
changed the title
TypographyFactory with IOText + Add support for Bold Text a11y settingTypographyFactory with IOText + Add support for Bold Text a11y setting
Affected stories
|
dmnplb
changed the title
TypographyFactory with IOText + Add support for Bold Text a11y settingTypographyFactory with IOText + Add support for Bold Text a11y setting
dmnplb
added
Dark mode 🌝
and removed
code review needed 💻📱
dmnplb
added a commit
that referenced
this pull request
Nov 13, 2024
…typographic styles, associated with the previous UI (#6299) ## Short description This PR removes legacy components related to the previous UI, including local typographic styles. This move is necessary because we need to get rid of the legacy typography to avoid typographic inconsistencies [once the `IOText` component is introduced](#6076). ## List of changes proposed in this pull request - Remove the following local typographic styles: `Body`, `H1`, `H2`, `H3`, `H4`, `H5`, `Monospace`, `Link`, `Label`, `LabelSmall`, `BaseTypography`, `ComposedBodyFromArray` - Remove `RobotoMono` typeface and its related references - Remove local `TypographyFactory` - Remove the following legacy components: `AdviceComponent`, `RawAccordion`, `DetailedListItemComponent`, `InfoBox` - Remove the following pages: `DSLegacyAccordion`, `DSLegacyTypography` ## How to test Navigate through the app and check that everything is OK. Keep in mind that some slight changes are normal because there isn't a perfect match between legacy and new typographic styles. --------- Co-authored-by: Emanuele Dall'Ara <[email protected]>
dmnplb
added a commit
that referenced
this pull request
Nov 22, 2024
…#6285) > [!important] > This PR is not directly dependent on the following PR. However, it needs the new `IOText` to avoid unnecessary extra work: > * #6076 ## Short description This PR extends dark mode support to some parts of the app ## List of changes proposed in this pull request - **General** - Adapt `LoadingSpinnerOverlay` - **Payments** - Adapt the payment biz event detail - Fix `ListItemTransaction` partial dark mode support - **Settings** - Adapt the fiscal code screen - Remove unnecessary `ContentWrapper` (by adding a new prop to `IOScrollViewWithLargeHeader`) - **Services** - Adapt the detail screens (footer actions not included because they need a general refactor) - **Messages** - Adapt `MessageDetailsFooter` ## How to test Run the app in the local environment, enable **Dark mode** and navigate through the entire app, in particular the screens mentioned above --------- Co-authored-by: Emanuele Dall'Ara <[email protected]> Co-authored-by: Alessandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR depends on:
io-app-design-systemfor accessibility improvements #6064Short description
This PR replaces the typographic styles generated through
useTypographyFactorywith the new genericIOTexttypographic style. It also adds the support for the Bold text a11y setting to all the existing typographic styles.List of changes proposed in this pull request
io-app-design-systemto2.0.0LabelLinkwith the relativeLabel…styles with the newasLinkpropDSTypographypage to reflect all the latest changesMdH4,MdH5andMdH6typographic styles because not necessaryPreview
bold-text.mov
How to test
To define