Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-2107,IOPID-2108] - A11Y adjust onboarding email insertion screen #6117

Merged
merged 13 commits into from
Sep 3, 2024

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Aug 26, 2024

Short description

Fixed some accessibility bugs, updated snapshots and updated react-native-reanimated config in jestConfig.js file.

List of changes proposed in this pull request

  • Upgrade DS lib version, more infos here
  • Fixed the focus behavior on keyboard key press
  • Updated snapshots
  • Updated jestConfig.js file

E2E

Tip

Run e2e tests

Demo

A11Y iOS
Before Announce Error Keypress Focus
iOS-a11y-email-insertion-before.mov
iOS-a11y-email-insertion-after.mov
iOS-a11y-email-insertion-keypress-after.mov
A11Y Android
Before Announce Error Keypress Focus
android-a11y-email-insertion-before.mp4
android-a11y-email-insertion-after.mp4
android-a11y-email-insertion-keypress-after.mp4

How to test

Using a physical device, enable the screen reader and interact with the EmailInsertScreen.

@ChrisMattew ChrisMattew self-assigned this Aug 26, 2024
@ChrisMattew ChrisMattew added a11y Activities related to accessibility IO-A&I IO - Autenticazione e Identità labels Aug 26, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOPID-2107,IOPID-2108] - A11Y adjust onboarding email insertion screen chore: [IOPID-2107,IOPID-2108] - A11Y adjust onboarding email insertion screen Aug 26, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 26, 2024

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • ⚙️ IOPID-2107: [APP] [Configura l'App] IO-24 - I messaggi di errore non vengono annunciati dalla TA, focus non gestito nella maniera corretta
    subtask of
    • IOPID-2066: Audit flussi autenticazione App IO
  • ⚙️ IOPID-2108: [APP] [Configura l'App] IO-25 - All'interazione con l'input da tastiera il focus torna all'inizio della pagina (perdita del focus)
    subtask of
    • IOPID-2066: Audit flussi autenticazione App IO

Generated by 🚫 dangerJS against 57e4747

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.77%. Comparing base (4f204b4) to head (57e4747).
Report is 447 commits behind head on master.

Files with missing lines Patch % Lines
ts/screens/profile/EmailInsertScreen.tsx 42.10% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6117      +/-   ##
==========================================
- Coverage   48.42%   47.77%   -0.65%     
==========================================
  Files        1488     1735     +247     
  Lines       31617    34912    +3295     
  Branches     7669     8380     +711     
==========================================
+ Hits        15311    16680    +1369     
- Misses      16238    18165    +1927     
+ Partials       68       67       -1     
Files with missing lines Coverage Δ
ts/screens/profile/EmailInsertScreen.tsx 47.82% <42.10%> (-0.24%) ⬇️

... and 1215 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b1812...57e4747. Read the comment docs.

@ChrisMattew ChrisMattew marked this pull request as ready for review August 28, 2024 15:42
@ChrisMattew ChrisMattew requested a review from a team as a code owner August 28, 2024 15:42
Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ladirico Ladirico merged commit 25cc67c into master Sep 3, 2024
13 checks passed
@Ladirico Ladirico deleted the IOPID-2108-a11y-first-onboarding-email-insertion branch September 3, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants