-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOCOM-1678] FIMS history single listItem error state #6136
Conversation
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6136 +/- ##
==========================================
- Coverage 48.42% 47.61% -0.82%
==========================================
Files 1488 1728 +240
Lines 31617 34841 +3224
Branches 7669 8334 +665
==========================================
+ Hits 15311 16589 +1278
- Misses 16238 18191 +1953
+ Partials 68 61 -7
... and 1186 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
addition of said error state when the service details' fetch fails.
![Screenshot 2024-08-30 at 12 38 40](https://private-user-images.githubusercontent.com/60693085/363141251-d0d1847b-c867-421f-8947-bfedae4302f5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NDc5NjEsIm5iZiI6MTczODk0NzY2MSwicGF0aCI6Ii82MDY5MzA4NS8zNjMxNDEyNTEtZDBkMTg0N2ItYzg2Ny00MjFmLTg5NDctYmZlZGFlNDMwMmY1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDE3MDEwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVmMDY5MDA4NzI0Y2E4Nzc2MTQwNTYwNDIyOGU3MGU4ZmIxNzgyOGRmYTM2OWIyZTRmYjA3MjkxMzY0MmNlNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.DhUzYOmtpE89gV1ULQgdpmNRJRPV2Hg0VEwxnjOvEbE)
List of changes proposed in this pull request
How to test
update the dev server's code to return the following line in
src/routers/service.ts, line 58/59
this way, as long as you have a big enough FIMS history list (dev-server, config.ts, I recommend something around 50),
you should be able to see some failed fetches.
make sure everything works as intended and follows the given design.