Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOCOM-1678] FIMS history single listItem error state #6136

Conversation

forrest57
Copy link
Contributor

@forrest57 forrest57 commented Aug 30, 2024

Short description

addition of said error state when the service details' fetch fails.
Screenshot 2024-08-30 at 12 38 40

List of changes proposed in this pull request

  • required I18n entries
  • addition of said component and its rendering logic

How to test

update the dev server's code to return the following line in src/routers/service.ts, line 58/59

                res.status(Math.random() > 0.3 ? 200 : 404).json(service)

this way, as long as you have a big enough FIMS history list (dev-server, config.ts, I recommend something around 50),
you should be able to see some failed fetches.
make sure everything works as intended and follows the given design.

@forrest57 forrest57 requested review from thisisjp and a team as code owners August 30, 2024 10:37
@forrest57 forrest57 marked this pull request as draft August 30, 2024 10:37
@forrest57 forrest57 changed the title [IOCOM-] [IOCOM-1678] FIMS history single listItem error state Aug 30, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1678] FIMS history single listItem error state chore: [IOCOM-1678] FIMS history single listItem error state Aug 30, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 30, 2024

Affected stories

  • ⚙️ IOCOM-1678: [APP] Implementare la schermata di errore nello storico FIMS per cui non è stato possibile recuperare i dati di un qualsiasi servizio
    subtask of
    • IOCOM-1659: [App] Attività implementative pre-rilascio

Generated by 🚫 dangerJS against 6f592b7

@forrest57 forrest57 marked this pull request as ready for review August 30, 2024 10:42
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.61%. Comparing base (4f204b4) to head (6f592b7).
Report is 432 commits behind head on master.

Files with missing lines Patch % Lines
...es/fims/history/components/FimsHistoryListItem.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6136      +/-   ##
==========================================
- Coverage   48.42%   47.61%   -0.82%     
==========================================
  Files        1488     1728     +240     
  Lines       31617    34841    +3224     
  Branches     7669     8334     +665     
==========================================
+ Hits        15311    16589    +1278     
- Misses      16238    18191    +1953     
+ Partials       68       61       -7     
Files with missing lines Coverage Δ
...es/fims/history/components/FimsHistoryListItem.tsx 25.00% <40.00%> (ø)

... and 1186 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc9874...6f592b7. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 merged commit 8c410f2 into master Aug 30, 2024
13 checks passed
@forrest57 forrest57 deleted the IOCOM-1678-app-implementare-la-schermata-di-errore-nello-storico-fims-per-cui-non-e-stato-possibile-recuperare-i-dati-di-un-qualsiasi-servizio branch August 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants