-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [PE-725] CGN merchant categories list details transition header #6313
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
813a2a6
fix: merchant categories list loader condition
LeleDallas 236bebd
Merge branch 'master' into PE-725-CGN-details-transition-header
LeleDallas c82b798
Merge branch 'master' into PE-725-CGN-details-transition-header
Hantex9 ebc7f38
Merge branch 'master' into PE-725-CGN-details-transition-header
Hantex9 e159214
Merge branch 'master' into PE-725-CGN-details-transition-header
Hantex9 1e60f0a
refactor: hasIcon property in merchant skeleton
LeleDallas 47e40a1
refactor: add skeleton in merchant categories list
LeleDallas 8a80e56
Merge branch 'master' into PE-725-CGN-details-transition-header
LeleDallas ea10276
Merge branch 'master' into PE-725-CGN-details-transition-header
LeleDallas b7a4bd7
refactor: merchant categories refresh condition
LeleDallas 25044df
Merge branch 'master' into PE-725-CGN-details-transition-header
LeleDallas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need two separate states to track this behavior? I believe we could manage with just one state that tracks the pull-to-refresh behavior. When the user opens this screen for the first time, the skeletons should always be shown as long as the pot is in a noneLoading state (i.e., both
pot.isNone
andpot.isLoading
). About the the pull-to-refresh, having a separate state makes sense, but for the initial load, a single state should be enough if you check if the pot is none but in loading. What do you think?