fix: [IOBP-901] Missing header in payment methods #6318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPAY and PayPal card header title missing case
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6318 +/- ##
==========================================
- Coverage 48.42% 46.99% -1.44%
==========================================
Files 1488 1804 +316
Lines 31617 36567 +4950
Branches 7669 8763 +1094
==========================================
+ Hits 15311 17183 +1872
- Misses 16238 19319 +3081
+ Partials 68 65 -3
... and 1422 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
thisisjp
reviewed
Oct 22, 2024
ts/features/payments/details/screens/PaymentsMethodDetailsScreen.tsx
Outdated
Show resolved
Hide resolved
LazyAfternoons
pushed a commit
that referenced
this pull request
Oct 23, 2024
## Short description This pull request includes a change to the `PaymentsMethodDetailsScreen` component to enhance the `getCardHeaderTitle` function. The update adds specific handling for BPAY and PayPal payment methods. ## List of changes proposed in this pull request - Update `getCardHeaderTitle` function to handle missing edge cases ## How to test ### io-dev-server To test all card cases, update the `generateWalletData` function by adding this line: `generateUserWallet(3)` ### io-app - Tap in _Portafoglio_ - BPAY or PayPal card - Verify the correct card header title is displayed --------- Co-authored-by: Alessandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request includes a change to the
PaymentsMethodDetailsScreencomponent to enhance thegetCardHeaderTitlefunction. The update adds specific handling for BPAY and PayPal payment methods.List of changes proposed in this pull request
getCardHeaderTitlefunction to handle missing edge casesHow to test
io-dev-server
To test all card cases, update the
generateWalletDatafunction by adding this line:generateUserWallet(3)io-app