-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-1934] Cleanup the integrityKeyTag if getWalletAttestation throws an error #6569
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1934 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6569 +/- ##
==========================================
+ Coverage 42.85% 49.23% +6.37%
==========================================
Files 1408 1555 +147
Lines 29557 32106 +2549
Branches 6659 7265 +606
==========================================
+ Hits 12668 15806 +3138
+ Misses 16860 16262 -598
- Partials 29 38 +9
... and 352 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…into siw-1934-integrity-key-clenaup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR updates the
WalletInstanceAttestationObtainment
machine step adding a cleanup function if there is an error.List of changes proposed in this pull request
getWalletAttestation
throws an errorHow to test
Ensure that, when creating a WI, after an error on the
WalletInstanceAttestationObtainment
step, theIntegrityKeyTag
has been correctly deleted, and a new key is generated when retrying to create a WI.