Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1934] Cleanup the integrityKeyTag if getWalletAttestation throws an error #6569

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

ale-mazz
Copy link
Contributor

@ale-mazz ale-mazz commented Dec 18, 2024

Short description

This PR updates the WalletInstanceAttestationObtainment machine step adding a cleanup function if there is an error.

List of changes proposed in this pull request

  • Added cleanupIntegrityKeyTag if getWalletAttestation throws an error

How to test

Ensure that, when creating a WI, after an error on the WalletInstanceAttestationObtainment step, the IntegrityKeyTag has been correctly deleted, and a new key is generated when retrying to create a WI.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1934

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.23%. Comparing base (fbe9e87) to head (f63cb09).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/itwallet/machine/eid/actions.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6569      +/-   ##
==========================================
+ Coverage   42.85%   49.23%   +6.37%     
==========================================
  Files        1408     1555     +147     
  Lines       29557    32106    +2549     
  Branches     6659     7265     +606     
==========================================
+ Hits        12668    15806    +3138     
+ Misses      16860    16262     -598     
- Partials       29       38       +9     
Files with missing lines Coverage Δ
...tures/itwallet/common/utils/itwAttestationUtils.ts 45.45% <ø> (+22.72%) ⬆️
ts/features/itwallet/machine/eid/machine.ts 97.05% <ø> (ø)
ts/features/itwallet/machine/eid/actions.ts 1.49% <0.00%> (-0.05%) ⬇️

... and 352 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a835a70...f63cb09. Read the comment docs.

@ale-mazz ale-mazz marked this pull request as ready for review December 18, 2024 16:40
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants