Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore [IOPID-2600] Add new content on carousel #6608

Merged
merged 9 commits into from
Jan 20, 2025

Conversation

Ladirico
Copy link
Contributor

Short description

In this PR, changes are made to the pictograms and texts contained in the carousel (visible when opening the app with the user not logged in).

Demo & A11Y

iOS Android
carousel_ios_a11y.MOV
carousel_android_a11y.mp4

How to test

Run the application( both on iOS and Android device) as not logged user and test if the carousel works as the demo video.

@Ladirico Ladirico added IO-A&I IO - Autenticazione e Identità copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. labels Jan 16, 2025
@Ladirico Ladirico self-assigned this Jan 16, 2025
@Ladirico Ladirico requested review from thisisjp, gispada, freddi301 and a team as code owners January 16, 2025 12:16
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2600

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.86%. Comparing base (b84f0d1) to head (141ee40).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6608   +/-   ##
=======================================
  Coverage   49.86%   49.86%           
=======================================
  Files        1564     1564           
  Lines       32358    32358           
  Branches     7336     7289   -47     
=======================================
  Hits        16135    16135           
- Misses      16173    16184   +11     
+ Partials       50       39   -11     
Files with missing lines Coverage Δ
ts/screens/authentication/LandingScreen.tsx 80.55% <ø> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f037ed...141ee40. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I've found a discrepancy between the pictogram of the actual DS and the one shown in the Figjam related to this screen. I also left a comment inside the Figjam.

@Ladirico
Copy link
Contributor Author

Ladirico commented Jan 20, 2025

LGTM, but I've found a discrepancy between the pictogram of the actual DS and the one in shown in the Figjam related to this screen. I also left a comment inside the Figjam.

Hi @shadowsheep1!
Thank you very much for noticing and commenting on the Figjam. I noticed that you did not approve the PR, but only commented on it. If you proceed with the approval my suggestion is to merge and proceed with an eventual fix later.
I would also ask @thisisjp for an opinion 😁

@Ladirico Ladirico requested a review from shadowsheep1 January 20, 2025 13:18
@thisisjp
Copy link
Contributor

@Ladirico @shadowsheep1 the figma wasn't aligned with the proper component, good catch! For the future: let's always stick with the pictograms part of the design system 💪

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ladirico Ladirico added this pull request to the merge queue Jan 20, 2025
Merged via the queue into master with commit 877ec8e Jan 20, 2025
21 checks passed
@Ladirico Ladirico deleted the IOPID-2600-new-carousel-content branch January 20, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants