-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore [IOPID-2600] Add new content on carousel #6608
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-2600 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6608 +/- ##
=======================================
Coverage 49.86% 49.86%
=======================================
Files 1564 1564
Lines 32358 32358
Branches 7336 7289 -47
=======================================
Hits 16135 16135
- Misses 16173 16184 +11
+ Partials 50 39 -11
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I've found a discrepancy between the pictogram of the actual DS and the one shown in the Figjam related to this screen. I also left a comment inside the Figjam.
Hi @shadowsheep1! |
@Ladirico @shadowsheep1 the figma wasn't aligned with the proper component, good catch! For the future: let's always stick with the pictograms part of the design system 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
In this PR, changes are made to the pictograms and texts contained in the carousel (visible when opening the app with the user not logged in).
Demo & A11Y
carousel_ios_a11y.MOV
carousel_android_a11y.mp4
How to test
Run the application( both on iOS and Android device) as not logged user and test if the carousel works as the demo video.