Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-1914] Paid payment badge from message details #6610

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Jan 16, 2025

Short description

This PR adds the PAID badge to a message in the messages home if the related check happens on the message details.

BadgePagato_low.mp4

List of changes proposed in this pull request

  • Paid badge reducer listens for the action that is dispatched by the payment update on the message details
  • Status is updated only if the information was not available yet, in order not to overwrite more detailed data that may have come from a complete payment flow

Be aware that a paid payment cannot change its status (so there is no case where data have to be removed from the paid badge reducer)

How to test

Using the io-dev-api-server, check that a paid payment generates the PAID label, if detected from the message details.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1914

@Vangaorth
Copy link
Contributor Author

@Hantex9 for a double check

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.61%. Comparing base (d76c8c9) to head (7c81600).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6610      +/-   ##
==========================================
+ Coverage   49.59%   49.61%   +0.02%     
==========================================
  Files        1564     1564              
  Lines       32355    32367      +12     
  Branches     7328     7332       +4     
==========================================
+ Hits        16045    16059      +14     
+ Misses      16261    16260       -1     
+ Partials       49       48       -1     
Files with missing lines Coverage Δ
ts/store/reducers/entities/payments.ts 92.00% <100.00%> (+7.38%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76c8c9...7c81600. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit eddd677 Jan 17, 2025
21 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1914_paidFromMessage branch January 17, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants