-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOCOM-1914] Paid payment badge from message details #6610
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOCOM-1914 |
@Hantex9 for a double check |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6610 +/- ##
==========================================
+ Coverage 49.59% 49.61% +0.02%
==========================================
Files 1564 1564
Lines 32355 32367 +12
Branches 7328 7332 +4
==========================================
+ Hits 16045 16059 +14
+ Misses 16261 16260 -1
+ Partials 49 48 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR adds the PAID badge to a message in the messages home if the related check happens on the message details.
BadgePagato_low.mp4
List of changes proposed in this pull request
Be aware that a paid payment cannot change its status (so there is no case where data have to be removed from the paid badge reducer)
How to test
Using the io-dev-api-server, check that a paid payment generates the PAID label, if detected from the message details.