Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ITWallet): [SIW-1985] Fix "ladybug" debugging tool issues #6611

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 17, 2025

Short description

This PR fixes the "ladybug" debugging tool issues, caused by an incorrect update of debug values in the Redux store

List of changes proposed in this pull request

  • Updated setDebugData action reducer
  • Updated debugDataSelector selector
  • Added strong type check on setDebugData action payload
  • Added test

How to test

Enable the Debug mode, navigate to screen where the "ladybug" debuggin tool is used (for example, the wallet and all the ITW routes). Check that values are correctly displayed.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1985

@mastro993 mastro993 changed the title [SIW-1985] Fix "ladybug" debugging tool issues fix(ITWallet): [SIW-1985] Fix "ladybug" debugging tool issues Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.12%. Comparing base (eddd677) to head (3569db4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6611      +/-   ##
==========================================
- Coverage   49.61%   48.12%   -1.50%     
==========================================
  Files        1564     1557       -7     
  Lines       32367    32329      -38     
  Branches     7284     7276       -8     
==========================================
- Hits        16059    15557     -502     
- Misses      16270    16736     +466     
+ Partials       38       36       -2     
Files with missing lines Coverage Δ
ts/store/actions/debug.ts 100.00% <100.00%> (ø)
ts/store/reducers/debug.ts 90.00% <100.00%> (+37.61%) ⬆️

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddd677...3569db4. Read the comment docs.

@mastro993 mastro993 self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant