Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:[IOCOM-1828] fims history list items tests #6614

Merged

Conversation

forrest57
Copy link
Contributor

Short description

addition of said tests

List of changes proposed in this pull request

  • splitted FimsHistoryListItem into two files for ease of testing and (arguably) cleanliness
  • addition of required tests, along with their snapshots
  • refactor following the file split

How to test

tests should solve correctly

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1828

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.88%. Comparing base (7667aac) to head (abe1cc9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../history/components/FimsHistoryNonEmptyContent.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6614      +/-   ##
==========================================
+ Coverage   49.85%   49.88%   +0.03%     
==========================================
  Files        1564     1565       +1     
  Lines       32379    32382       +3     
  Branches     7290     7291       +1     
==========================================
+ Hits        16141    16154      +13     
+ Misses      16200    16189      -11     
- Partials       38       39       +1     
Files with missing lines Coverage Δ
...s/history/components/FimsHistoryListItemPicker.tsx 100.00% <100.00%> (ø)
...s/fims/history/components/FimsHistoryListItems.tsx 100.00% <100.00%> (ø)
.../history/components/FimsHistoryNonEmptyContent.tsx 5.88% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7667aac...abe1cc9. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 enabled auto-merge January 22, 2025 14:14
@forrest57 forrest57 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit cc99fab Jan 22, 2025
22 checks passed
@forrest57 forrest57 deleted the IOCOM-1828-app-test-automatici-fims-history-list-item branch January 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants