-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-1986] Persist ITW store after logout #6619
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1986 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6619 +/- ##
=======================================
Coverage 49.88% 49.88%
=======================================
Files 1565 1565
Lines 32382 32384 +2
Branches 7288 7290 +2
=======================================
+ Hits 16154 16156 +2
Misses 16190 16190
Partials 38 38
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The itWallet
state is correctly persisted after logout.
PR Title Validation for conventional commit type✅ All good! PR title follows conventional commit type. |
Short description
This PR fixes the ITW stores persistence after the
logoutSuccess
,logoutFailure
actions dispatchSteps to reproduce
List of changes proposed in this pull request
itwLifecycleStoresReset
in the preferences reducer to handle the ITW resetcreareRootReducer
How to test
Tests should pass.
The bug could not be reproduced