Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1986] Persist ITW store after logout #6619

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 20, 2025

Short description

This PR fixes the ITW stores persistence after the logoutSuccess, logoutFailure actions dispatch

Steps to reproduce

  1. Open the app and log in
  2. Update some preference, for example, the ITW feedback banner visibility
  3. Log out of the app
  4. Log back into the app
  5. Verify the banner visibility:
    • Expected: the banner remains hidden
    • Actual: the banner is visible again, indicating that the preferences was not persisted

List of changes proposed in this pull request

  • Added itwLifecycleStoresReset in the preferences reducer to handle the ITW reset
  • Added ITW store data persistence in creareRootReducer

How to test

Tests should pass.
The bug could not be reproduced

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1986

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.88%. Comparing base (cc99fab) to head (fbdf3fb).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6619   +/-   ##
=======================================
  Coverage   49.88%   49.88%           
=======================================
  Files        1565     1565           
  Lines       32382    32384    +2     
  Branches     7288     7290    +2     
=======================================
+ Hits        16154    16156    +2     
  Misses      16190    16190           
  Partials       38       38           
Files with missing lines Coverage Δ
...ures/itwallet/common/store/reducers/preferences.ts 95.00% <100.00%> (+0.55%) ⬆️
ts/store/reducers/index.ts 40.74% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc99fab...fbdf3fb. Read the comment docs.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The itWallet state is correctly persisted after logout.

@mastro993 mastro993 enabled auto-merge January 22, 2025 15:56
Copy link
Contributor

PR Title Validation for conventional commit type

✅ All good! PR title follows conventional commit type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants