-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-1959] Remove ITW credentials placeholders from wallet #6620
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue SIW-1959 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6620 +/- ##
==========================================
- Coverage 49.88% 49.88% -0.01%
==========================================
Files 1565 1566 +1
Lines 32382 32383 +1
Branches 7288 7336 +48
==========================================
Hits 16154 16154
- Misses 16190 16191 +1
Partials 38 38
Continue to review full report in Codecov by Sentry.
|
PR Title Validation for conventional commit type❌ PR title is invalid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR resolves an issue where, under certain conditions, credential placeholders remained visible even after the IT Wallet was disabled.
List of changes proposed in this pull request
walletRemoveCardsByCategory
action to remove all cards of a given categorywalletRemoveCardsByCategory("itw")
dispatch when IT Wallet is correctly disabled or the WI is revokedItwWalletCardsContainer
underitwallet
feature folderItwWalletCardsContainer
is no more rendered if the wallet is not in a valid statusHow to test
Check that everything works as expected and no placeholders are still visibile after disabling the IT Wallet.