Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1959] Remove ITW credentials placeholders from wallet #6620

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 21, 2025

Short description

This PR resolves an issue where, under certain conditions, credential placeholders remained visible even after the IT Wallet was disabled.

List of changes proposed in this pull request

  • Added walletRemoveCardsByCategory action to remove all cards of a given category
  • Added walletRemoveCardsByCategory("itw") dispatch when IT Wallet is correctly disabled or the WI is revoked
  • Moved ItwWalletCardsContainer under itwallet feature folder
  • ItwWalletCardsContainer is no more rendered if the wallet is not in a valid status

How to test

Check that everything works as expected and no placeholders are still visibile after disabling the IT Wallet.

@mastro993 mastro993 self-assigned this Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue SIW-1959

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.88%. Comparing base (cc99fab) to head (69e7582).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/wallet/store/selectors/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6620      +/-   ##
==========================================
- Coverage   49.88%   49.88%   -0.01%     
==========================================
  Files        1565     1566       +1     
  Lines       32382    32383       +1     
  Branches     7288     7336      +48     
==========================================
  Hits        16154    16154              
- Misses      16190    16191       +1     
  Partials       38       38              
Files with missing lines Coverage Δ
...s/discoveryBanner/ItwDiscoveryBannerStandalone.tsx 100.00% <ø> (ø)
...et/lifecycle/saga/handleWalletInstanceResetSaga.ts 100.00% <100.00%> (ø)
...llet/wallet/components/ItwWalletCardsContainer.tsx 100.00% <100.00%> (ø)
...eatures/wallet/components/WalletCardsContainer.tsx 100.00% <ø> (ø)
ts/features/wallet/store/actions/cards.ts 100.00% <100.00%> (ø)
ts/features/wallet/store/reducers/cards.ts 97.36% <100.00%> (+0.22%) ⬆️
ts/features/wallet/store/selectors/index.ts 89.58% <0.00%> (-1.91%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc99fab...69e7582. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR Title Validation for conventional commit type

❌ PR title is invalid.
It must follow the format type(context): description.
Valid types are: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 changed the title fix(IT Wallet) [SIW-1959] Remove ITW credentials placeholders from wallet fix(IT Wallet): [SIW-1959] Remove ITW credentials placeholders from wallet Jan 22, 2025
@mastro993 mastro993 enabled auto-merge January 22, 2025 16:00
@mastro993 mastro993 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit f808e29 Jan 22, 2025
23 of 24 checks passed
@mastro993 mastro993 deleted the SIW-1959-fix-itw-wallet-placeholders branch January 22, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants