Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CGN): [PE-916] Clear cache when reloading CGN webview component #6632

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Jan 23, 2025

Short description

This PR clears the webview cache when reloading the webpage.

List of changes proposed in this pull request

  • Added the clearCache invocation.

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue PE-916

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.88%. Comparing base (bb33c2f) to head (ee1dc05).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/components/WebviewComponent.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6632      +/-   ##
==========================================
- Coverage   49.88%   49.88%   -0.01%     
==========================================
  Files        1566     1566              
  Lines       32389    32390       +1     
  Branches     7291     7289       -2     
==========================================
  Hits        16158    16158              
- Misses      16192    16194       +2     
+ Partials       39       38       -1     
Files with missing lines Coverage Δ
ts/components/WebviewComponent.tsx 44.44% <0.00%> (-2.62%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb33c2f...ee1dc05. Read the comment docs.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think to use this PR also to cover the missing test for WebviewComponent.tsx?

@Hantex9
Copy link
Contributor Author

Hantex9 commented Jan 23, 2025

What do you think to use this PR also to cover the missing test for WebviewComponent.tsx?

I agree with you but currently this PR must be merged before the Beta of this afternoon because this is causing a bug in production to some merchants. I added the task in the CGN board about adding tests for this component, in this case we can work on missing tests in a second PR. What do you think?

@Hantex9 Hantex9 added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit d5ae637 Jan 23, 2025
21 checks passed
@Hantex9 Hantex9 deleted the PE-916-clear-cache-cgn-playground branch January 23, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants