-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CGN): [PE-916] Clear cache when reloading CGN webview component #6632
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue PE-916 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6632 +/- ##
==========================================
- Coverage 49.88% 49.88% -0.01%
==========================================
Files 1566 1566
Lines 32389 32390 +1
Branches 7291 7289 -2
==========================================
Hits 16158 16158
- Misses 16192 16194 +2
+ Partials 39 38 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think to use this PR also to cover the missing test for WebviewComponent.tsx
?
I agree with you but currently this PR must be merged before the Beta of this afternoon because this is causing a bug in production to some merchants. I added the task in the CGN board about adding tests for this component, in this case we can work on missing tests in a second PR. What do you think? |
Short description
This PR clears the webview cache when reloading the webpage.
List of changes proposed in this pull request
clearCache
invocation.