chore:[IOPID-2162] Remove CieID FF

locales/en/index.yml

@@ -483,9 +483,6 @@ profile:
     idpay:
       idpayTest: IDPay
       idpayTestAlert: This change requires app reboot
-    cieID:
-      cieIdTest:
-        title: CieID
     designSystemEnvironment: Experimental Design System
     newScanSection: New 'Scan' feature
     sessionRefresh: Activate Session Refresh

locales/it/index.yml

@@ -483,9 +483,6 @@ profile:
     idpay:
       idpayTest: IDPay
       idpayTestAlert: La modifica richiede il riavvio dell'app
-    cieID:
-      cieIdTest:
-        title: CieID
     trial:
       titleSection: Partecipa alla sperimentazione
     designSystemEnvironment: Design System sperimentale

ts/features/cieLogin/store/actions/index.ts

@@ -7,10 +7,6 @@ export const cieLoginDisableUat = createStandardAction(
   "CIE_LOGIN_DISABLE_UAT"
 )();
 
-export const cieIDFeatureSetEnabled = createStandardAction(
-  "PREFERENCES_CIE_ID_FEATURE_SET_ENABLED"
-)<{ isCieIDFeatureEnabled: boolean }>();
-
 export const cieIDDisableTourGuide = createStandardAction(
   "CIE_ID_DISABLE_TOUR_GUIDE"
 )();
@@ -21,6 +17,5 @@ export const cieIDSetSelectedSecurityLevel = createStandardAction(
 export type CieLoginConfigActions =
   | ActionType<typeof cieLoginDisableUat>
   | ActionType<typeof cieLoginEnableUat>
-  | ActionType<typeof cieIDFeatureSetEnabled>
   | ActionType<typeof cieIDDisableTourGuide>
   | ActionType<typeof cieIDSetSelectedSecurityLevel>;

ts/features/cieLogin/store/reducers/index.ts

@@ -7,10 +7,9 @@ import {
   PersistedState,
   persistReducer
 } from "redux-persist";
-import { merge } from "lodash";
+import { omit } from "lodash";
 import {
   cieIDDisableTourGuide,
-  cieIDFeatureSetEnabled,
   cieIDSetSelectedSecurityLevel,
   cieLoginDisableUat,
   cieLoginEnableUat
@@ -21,14 +20,12 @@ import { SpidLevel } from "../../utils";
 
 export type CieLoginState = {
   useUat: boolean;
-  isCieIDFeatureEnabled: boolean;
   isCieIDTourGuideEnabled: boolean;
   cieIDSelectedSecurityLevel?: SpidLevel;
 };
 
 export const cieLoginInitialState = {
   useUat: false,
-  isCieIDFeatureEnabled: false,
   isCieIDTourGuideEnabled: true
 };
 
@@ -47,11 +44,6 @@ const cieLoginReducer = (
         ...state,
         useUat: false
       };
-    case getType(cieIDFeatureSetEnabled):
-      return {
-        ...state,
-        ...action.payload
-      };
     case getType(cieIDDisableTourGuide):
       return {
         ...state,
@@ -67,19 +59,26 @@ const cieLoginReducer = (
   }
 };
 
-const CURRENT_REDUX_CIE_LOGIN_STORE_VERSION = 0;
+const CURRENT_REDUX_CIE_LOGIN_STORE_VERSION = 1;
 
 const migrations: MigrationManifest = {
-  "0": (state: PersistedState) =>
-    merge(state, "features.loginFeatures.cieLogin.isCieIDTourGuideEnabled")
+  "0": (state: PersistedState) => ({
+    ...state,
+    isCieIDTourGuideEnabled: true
+  }),
+  /**
+   * @param state The slice state
+   * Removes `isCieIDFeatureEnabled` from the persist rehydration actions
+   */
+  "1": (state: PersistedState) => omit(state, "isCieIDFeatureEnabled")
 };
 
 const persistConfig: PersistConfig = {
   key: "cieLogin",
   storage: AsyncStorage,
   migrate: createMigrate(migrations, { debug: isDevEnv }),
   version: CURRENT_REDUX_CIE_LOGIN_STORE_VERSION,
-  whitelist: ["isCieIDFeatureEnabled", "isCieIDTourGuideEnabled"]
+  whitelist: ["isCieIDTourGuideEnabled"]
 };
 
 export const cieLoginPersistor = persistReducer<CieLoginState, Action>(

ts/features/cieLogin/store/selectors/index.ts

@@ -1,34 +1,10 @@
-import { createSelector } from "reselect";
 import { GlobalState } from "../../../../store/reducers/types";
-import { remoteConfigSelector } from "../../../../store/reducers/backendStatus/remoteConfig";
-import { isPropertyWithMinAppVersionEnabled } from "../../../../store/reducers/featureFlagWithMinAppVersionStatus";
 
 export const isCieLoginUatEnabledSelector = (state: GlobalState) =>
   state.features.loginFeatures.cieLogin.useUat;
 
-const isCieIdMinAppVersionEnabledSelector = createSelector(
-  remoteConfigSelector,
-  remoteConfig =>
-    isPropertyWithMinAppVersionEnabled({
-      remoteConfig,
-      mainLocalFlag: true,
-      configPropertyName: "cie_id"
-    })
-);
-
-export const isCieIDLocalFeatureEnabledSelector = (state: GlobalState) =>
-  state.features.loginFeatures.cieLogin.isCieIDFeatureEnabled;
-
-export const isCieIDFFEnabledSelector = (state: GlobalState) =>
-  isCieIDLocalFeatureEnabledSelector(state) ||
-  isCieIdMinAppVersionEnabledSelector(state);
-
-/**
- * Both `isCieIDTourGuideEnabled` and `isCieIDFFEnabledSelector` return value must be `true`
- */
 export const isCieIDTourGuideEnabledSelector = (state: GlobalState) =>
-  state.features.loginFeatures.cieLogin.isCieIDTourGuideEnabled &&
-  isCieIDFFEnabledSelector(state);
+  state.features.loginFeatures.cieLogin.isCieIDTourGuideEnabled;
 
 export const cieIDSelectedSecurityLevelSelector = (state: GlobalState) =>
   state.features.loginFeatures.cieLogin.cieIDSelectedSecurityLevel;

ts/features/common/store/reducers/__tests__/__snapshots__/index.test.ts.snap

@@ -144,7 +144,6 @@ exports[`featuresPersistor should match snapshot 1`] = `
   },
   "loginFeatures": {
     "cieLogin": {
-      "isCieIDFeatureEnabled": false,
       "isCieIDTourGuideEnabled": true,
       "useUat": false,
     },

ts/navigation/AuthenticationNavigator.tsx

@@ -15,7 +15,6 @@ import CieExpiredOrInvalidScreen from "../screens/authentication/cie/CieExpiredO
 import CiePinScreen from "../screens/authentication/cie/CiePinScreen";
 import CieWrongCiePinScreen from "../screens/authentication/cie/CieWrongCiePinScreen";
 import { AuthSessionPage } from "../screens/authentication/idpAuthSessionHandler";
-import CieNotSupported from "../components/cie/CieNotSupported";
 import RootedDeviceModal from "../screens/modal/RootedDeviceModal";
 import { isGestureEnabled } from "../utils/navigation";
 import CieUnexpectedErrorScreen from "../screens/authentication/cie/CieUnexpectedErrorScreen";
@@ -201,11 +200,6 @@ const AuthenticationStackNavigator = () => (
         headerShown: true
       }}
     >
-      <Stack.Screen
-        name={ROUTES.CIE_NOT_SUPPORTED}
-        component={CieNotSupported}
-      />
-
       <Stack.Screen
         options={{ headerShown: true }}
         name={ROUTES.CIE_ACTIVATE_NFC_SCREEN}

ts/navigation/params/AuthenticationParamsList.ts

@@ -17,7 +17,6 @@ export type AuthenticationParamsList = {
   [ROUTES.AUTHENTICATION_IDP_LOGIN]: undefined;
   [ROUTES.AUTHENTICATION_AUTH_SESSION]: undefined;
   [ROUTES.AUTHENTICATION_IDP_TEST]: undefined;
-  [ROUTES.CIE_NOT_SUPPORTED]: undefined;
   [ROUTES.CIE_ACTIVATE_NFC_SCREEN]: CieCardReaderScreenNavigationParams;
   [ROUTES.AUTH_ERROR_SCREEN]: AuthErrorScreenProps;
   [ROUTES.UNLOCK_ACCESS_SCREEN]: UnlockAccessProps;

ts/navigation/routes.ts

@@ -14,7 +14,6 @@ const ROUTES = {
   AUTHENTICATION_IDP_LOGIN: "AUTHENTICATION_IDP_LOGIN",
   AUTHENTICATION_AUTH_SESSION: "AUTHENTICATION_AUTH_SESSION",
   AUTHENTICATION_IDP_TEST: "AUTHENTICATION_IDP_TEST",
-  CIE_NOT_SUPPORTED: "CIE_NOT_SUPPORTED",
   CIE_NOT_INSTALLED: "CIE_NOT_INSTALLED",
   CIE_ACTIVATE_NFC_SCREEN: "CIE_ACTIVATE_NFC_SCREEN",
   AUTH_ERROR_SCREEN: "AUTH_ERROR_SCREEN",