Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [IOCOM-1824,IOCOM-1825] fims history emptyContent and index saga tests #6654

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

forrest57
Copy link
Contributor

Short description

addition of tests for said files

List of changes proposed in this pull request

  • tests for fims history index saga
  • tests and snapshot for fims history empty content component
  • mock for fims history header

How to test

automatic tests should pass.

@forrest57 forrest57 changed the title [IOCOM-1824, IOCOM-1825] fims history emtpyContent and index saga tests test: [IOCOM-1824, IOCOM-1825] fims history emtpyContent and index saga tests Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@forrest57 forrest57 changed the title test: [IOCOM-1824, IOCOM-1825] fims history emtpyContent and index saga tests test: [IOCOM-1824, IOCOM-1825] fims history emptyContent and index saga tests Jan 29, 2025
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.81%. Comparing base (f8317b5) to head (3013080).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6654      +/-   ##
==========================================
+ Coverage   49.79%   49.81%   +0.01%     
==========================================
  Files        1541     1541              
  Lines       32154    32154              
  Branches     7285     7286       +1     
==========================================
+ Hits        16012    16016       +4     
+ Misses      16103    16087      -16     
- Partials       39       51      +12     

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8317b5...3013080. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants