chore: [IOPLT-946] Update the main icon app for iOS + Add support for dark and tinted appearances #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
Design System
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6655 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 1544 1544
Lines 32163 32163
Branches 7292 7240 -52
=======================================
Hits 16079 16079
- Misses 16033 16046 +13
+ Partials 51 38 -13 see 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CrisTofani
approved these changes
Feb 3, 2025
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The new app icon is only supported in XCode
16.xand above. We need to update it first, in order for the app distribution to work. This change is covered by the related PR.Depends on #6664
Short description
This PR updates the main icon app for iOS and adds support for dark and tinted appearances. We have already tried to update them, but this change blocked the app distribution at a critical time, the launch of IT Wallet.
List of changes proposed in this pull request
1024×1024size for default, dark and tinted appearancesPreview
dynamic-app-icons.mp4
How to test