Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-1921] FIMS - Back navigation upon InApp Browser closing #6659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR moves the automatic back navigation on the InApp Browser closing event (for the FIMS flow)

Android iOS
Android.mov
iOS.mov

List of changes proposed in this pull request

  • FIMS success action and back navigation moved to the finally clause of the InApp Browser opening try-catch

How to test

Using the io-dev-api-server, check that there is no back navigation until the InApp Browser has been closed

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.82%. Comparing base (bbc03d2) to head (2030593).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../saga/handleFimsAuthorizationOrImplicitCodeFlow.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6659   +/-   ##
=======================================
  Coverage   49.82%   49.82%           
=======================================
  Files        1541     1541           
  Lines       32154    32154           
  Branches     7284     7236   -48     
=======================================
  Hits        16021    16021           
- Misses      16082    16093   +11     
+ Partials       51       40   -11     
Files with missing lines Coverage Δ
.../saga/handleFimsAuthorizationOrImplicitCodeFlow.ts 4.25% <0.00%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3c456...2030593. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant