feat:[IOPID-2619] New PosteID App2App educational bottom sheet #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6665 +/- ##
==========================================
- Coverage 50.04% 50.02% -0.03%
==========================================
Files 1539 1540 +1
Lines 32187 32204 +17
Branches 7305 7309 +4
==========================================
+ Hits 16109 16110 +1
- Misses 16028 16043 +15
- Partials 50 51 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisMattew
added
IO-A&I
ChrisMattew
requested review from
thisisjp,
gispada,
freddi301 and
a team
as code owners
|
@mariateresaventura copy review needed 🙏🏻 |
mariateresaventura
temporarily deployed
to
dev
GitHub Actions
Inactive
mariateresaventura
temporarily deployed
to
dev
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR aims to direct citizens who select the login with PosteID towards the app2app approach (if they have the PosteID app on their device) to optimize the login process.
List of changes proposed in this pull request
bottom-sheetperformancebottom-sheetto theIdpLoginScreen, which is displayed when the citizen selectsPoste IDDemo
android-posteid-app2app-educational.mp4
iOS-posteid-app2app-educational.MP4
A11Y
android-a11y-posteid-app2app-educational.mp4
iOS-a11y-posteid-app2app-educational.MP4
How to test
In the production environment, try selecting different
idpoptions (it's not necessary to proceed with the login). Thebottom-sheetshould appear only when selecting the Poste IDidp(as shown in the demo). Make sure everything works correctly.